c96bc36fed
* fix: fix improper authorization when accessing with third-party application
* refactor: refactor type definitions
* fix: get rid of unnecessary access limitation
* enhance: サードパーティアプリケーションがWebsocket APIを使えるように
* fix: add missing parentheses
* Revert "fix(backend): add missing kind definition for admin endpoints to improve security"
This reverts commit 5150053275.
* frontend: 翻訳の抜けを訂正, read:adminとwrite:adminはアクセス発行トークンのデフォルトでは非表示にする
* enhance(test): misskey-ghsa-7pxq-6xx9-xpgmに関するテストを追加
* enhance(test): Websocket APIに対するテストも追加
* enhance(refactor): `@/misc/api-permissions.ts`を`misskey-js/permissions`に統合
* fix(frontend): アクセストークン発行UIで全ての権限を有効にした際、管理者用APIへのアクセスも許可してしまう問題を修正
* enhance(backend): Websocketの接続に最低限必要な権限を変更
* fix(backend): `/api/admin/meta`をサードパーティアプリケーションからはアクセスできないように
* fix(backend): エンドポイントにアクセスするために必要な権限を変更
* fix(frontend/locale): Add missing type declaration
* chore: update `misskey-js/src/autogen`
---------
Co-authored-by: tamaina <tamaina@hotmail.co.jp>
74 lines
2.3 KiB
TypeScript
74 lines
2.3 KiB
TypeScript
/*
|
|
* SPDX-FileCopyrightText: syuilo and other misskey contributors
|
|
* SPDX-License-Identifier: AGPL-3.0-only
|
|
*/
|
|
|
|
import { Inject, Injectable } from '@nestjs/common';
|
|
import { Endpoint } from '@/server/api/endpoint-base.js';
|
|
import type { AnnouncementsRepository } from '@/models/_.js';
|
|
import { DI } from '@/di-symbols.js';
|
|
import { AnnouncementService } from '@/core/AnnouncementService.js';
|
|
import { ApiError } from '../../../error.js';
|
|
|
|
export const meta = {
|
|
tags: ['admin'],
|
|
|
|
requireCredential: true,
|
|
requireModerator: true,
|
|
kind: 'write:admin:announcements',
|
|
|
|
errors: {
|
|
noSuchAnnouncement: {
|
|
message: 'No such announcement.',
|
|
code: 'NO_SUCH_ANNOUNCEMENT',
|
|
id: 'd3aae5a7-6372-4cb4-b61c-f511ffc2d7cc',
|
|
},
|
|
},
|
|
} as const;
|
|
|
|
export const paramDef = {
|
|
type: 'object',
|
|
properties: {
|
|
id: { type: 'string', format: 'misskey:id' },
|
|
title: { type: 'string', minLength: 1 },
|
|
text: { type: 'string', minLength: 1 },
|
|
imageUrl: { type: 'string', nullable: true, minLength: 0 },
|
|
icon: { type: 'string', enum: ['info', 'warning', 'error', 'success'] },
|
|
display: { type: 'string', enum: ['normal', 'banner', 'dialog'] },
|
|
forExistingUsers: { type: 'boolean' },
|
|
silence: { type: 'boolean' },
|
|
needConfirmationToRead: { type: 'boolean' },
|
|
isActive: { type: 'boolean' },
|
|
},
|
|
required: ['id'],
|
|
} as const;
|
|
|
|
@Injectable()
|
|
export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint-disable-line import/no-default-export
|
|
constructor(
|
|
@Inject(DI.announcementsRepository)
|
|
private announcementsRepository: AnnouncementsRepository,
|
|
|
|
private announcementService: AnnouncementService,
|
|
) {
|
|
super(meta, paramDef, async (ps, me) => {
|
|
const announcement = await this.announcementsRepository.findOneBy({ id: ps.id });
|
|
|
|
if (announcement == null) throw new ApiError(meta.errors.noSuchAnnouncement);
|
|
|
|
await this.announcementService.update(announcement, {
|
|
updatedAt: new Date(),
|
|
title: ps.title,
|
|
text: ps.text,
|
|
/* eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- 空の文字列の場合、nullを渡すようにするため */
|
|
imageUrl: ps.imageUrl || null,
|
|
display: ps.display,
|
|
icon: ps.icon,
|
|
forExistingUsers: ps.forExistingUsers,
|
|
silence: ps.silence,
|
|
needConfirmationToRead: ps.needConfirmationToRead,
|
|
isActive: ps.isActive,
|
|
}, me);
|
|
});
|
|
}
|
|
}
|