Commit Graph

9 Commits

Author SHA1 Message Date
Johann150
804fa33535
refactor: improve code quality (#8751)
* remove unnecessary if

`Array.prototype.some` already returns a boolean so an if to return
true or false is completely unnecessary in this case.

* perf: use count instead of find

When using `count` instead of `findOneBy`, the data is not
unnecessarily loaded.

* remove duplicate null check

The variable is checked for null in the lines above and the function
returns if so. Therefore, it can not be null at this point.

* simplify `getJsonSchema`

Because the assigned value is `null` and the used keys are only
shallow, use of `nestedProperty.set` seems inappropriate. Because the
value is not read, the initial for loop can be replaced by a `for..in`
loop.

Since all keys will be assigned `null`, the condition of the ternary
expression in the nested function will always be true. Therefore the
recursion case will never happen. With this the nested function can be
eliminated.

* remove duplicate condition

The code above already checks `dragging` and returns if it is truthy.
Checking it again later is therefore unnecessary.

To make this more obvious the `return` is removed in favour of using
an if...else construct.

* remove impossible "unknown" time

The `ago` variable will always be a number and all non-negative numbers
are already covered by other cases, the negative case is handled with
`future` so there is no case when `unkown` could be achieved.
2022-05-29 15:15:52 +09:00
Andreas Nedbal
a273940348
fix(client): fix lint issues in Deck UI components (#8681) 2022-05-19 17:35:43 +09:00
tamaina
f7030d4a42
enhance: タッチパッド・タッチスクリーンでのデッキの操作性を向上 (#8450)
* enhance experience of deck with touchpad

* test: 単純にdeltaYを加算してみる

* clean up

* ios bug fix?

* ✌️

* use overflow-y

* Safari does not supports clip
2022-04-02 15:12:01 +09:00
tamaina
78736c70f7
デッキまわりをCompositon API / Setup Sugarに (#8410)
* universal.widgets.vue

* column.vue, antenna-column.vue

* direct-column.vue, list-column.vue

* main-column.vue

* wip

* ✌️

* fix

* ✌️

* ✌️
2022-03-21 03:11:14 +09:00
syuilo
a8fad1b61c refactor 2022-01-18 21:35:57 +09:00
syuilo
8322c90834 refactor(client): specify global scope 2022-01-16 10:14:14 +09:00
syuilo
4f208b99ff enhance(client): improve usability 2021-12-03 22:22:08 +09:00
syuilo
5d968afa74 update linr 2021-11-19 19:36:12 +09:00
syuilo
0e4a111f81 refactoring
Resolve #7779
2021-11-12 02:02:25 +09:00