code cleanup (MisskeyIO#825)

packages/backend/src/core/FileInfoService.ts

@@ -273,7 +273,9 @@ export class FileInfoService {
 			watcher.close();
 		});
 		command.run();
-		for (let i = 1; true; i++) { // eslint-disable-line @typescript-eslint/no-unnecessary-condition
+		let i = 0;
+		while (true) {
+			i++;
 			const current = `${i}.png`;
 			const next = `${i + 1}.png`;
 			const framePath = join(cwd, current);

packages/backend/src/decorators.ts

@@ -20,8 +20,7 @@ export function bindThis(target: any, key: string, descriptor: any) {
 	return {
 		configurable: true,
 		get() {
-			// eslint-disable-next-line no-prototype-builtins
-			if (this === target.prototype || this.hasOwnProperty(key) ||
+			if (this === target.prototype || Object.hasOwn(this, key) ||
         typeof fn !== 'function') {
 				return fn;
 			}

packages/backend/src/server/oauth/OAuth2ProviderService.ts

@@ -195,7 +195,7 @@ function getQueryMode(issuerUrl: string): oauth2orize.grant.Options['modes'] {
 				parsed.searchParams.append(key, value as string);
 			}
 
-			return (res as OAuthHttpResponse).redirect(parsed.toString());
+			(res as OAuthHttpResponse).redirect(parsed.toString());
 		},
 	};
 }

packages/backend/src/server/web/bios.css

@@ -5,7 +5,7 @@
  */
 
 * {
-	font-family: Fira code, Fira Mono, Consolas, Menlo, Courier, monospace;
+	font-family: 'Fira code', 'Fira Mono', Consolas, Menlo, Courier, monospace;
 }
 
 html {

packages/backend/src/server/web/boot.js

@@ -33,7 +33,7 @@
 	}
 
 	//#region Detect language & fetch translations
-	if (!localStorage.hasOwnProperty('locale')) {
+	if (!Object.hasOwn(localStorage, 'locale')) {
 		let lang = localStorage.getItem('lang');
 		if (lang == null || lang.toString == null || lang.toString() === 'null') {
 			lang = 'ja-JP';

packages/backend/src/server/web/cli.css

@@ -5,7 +5,7 @@
  */
 
 * {
-	font-family: Fira code, Fira Mono, Consolas, Menlo, Courier, monospace;
+	font-family: 'Fira code', 'Fira Mono', Consolas, Menlo, Courier, monospace;
 }
 
 html {

packages/backend/src/server/web/flush.js

@@ -39,7 +39,7 @@ message('Start flushing.');
 
         console.error(e);
         setTimeout(() => {
-            location = '/';
+            window.location = '/';
         }, 10000)
     }
 })();

packages/backend/test-server/tsconfig.json

@@ -9,7 +9,7 @@
 		"noFallthroughCasesInSwitch": true,
 		"declaration": false,
 		"sourceMap": true,
-		"target": "ES2022",
+		"target": "es2022",
 		"module": "nodenext",
 		"moduleResolution": "nodenext",
 		"allowSyntheticDefaultImports": true,

packages/backend/test/tsconfig.json

@@ -9,7 +9,7 @@
 		"noFallthroughCasesInSwitch": true,
 		"declaration": false,
 		"sourceMap": true,
-		"target": "ES2022",
+		"target": "es2022",
 		"module": "nodenext",
 		"moduleResolution": "nodenext",
 		"allowSyntheticDefaultImports": true,

packages/backend/test/unit/ap-request.ts

@@ -9,7 +9,7 @@ import httpSignature from '@peertube/http-signature';
 import { genRsaKeyPair } from '@/misc/gen-key-pair.js';
 import { ApRequestCreator } from '@/core/activitypub/ApRequestService.js';
 
-export const buildParsedSignature = (signingString: string, signature: string, algorithm: string) => {
+const buildParsedSignature = (signingString: string, signature: string, algorithm: string) => {
 	return {
 		scheme: 'Signature',
 		params: {

packages/backend/tsconfig.json

@@ -9,7 +9,7 @@
 		"noFallthroughCasesInSwitch": true,
 		"declaration": false,
 		"sourceMap": false,
-		"target": "ES2022",
+		"target": "es2022",
 		"module": "nodenext",
 		"moduleResolution": "nodenext",
 		"allowSyntheticDefaultImports": true,