oscar-surf/misskey
oscar-surf/misskey
0
0
Fork 0
Code Issues Activity

fix(frontend/scroll): no callback for disconnected elements (#11714)

Browse source 
* fix(frontend/scroll): no callback for disconnected elements

* Update CHANGELOG.md
This commit is contained in:
Kagami Sascha Rosylight 2023-08-13 14:22:57 +02:00 • committed by GitHub
parent bbef2a953e
commit ab58b651f7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 69 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

64
packages/frontend/test/scroll.test.ts Normal file
View file

@ -0,0 +1,64 @@
/*
* SPDX-FileCopyrightText: syuilo and other misskey contributors
* SPDX-License-Identifier: AGPL-3.0-only
*/
import { describe, test, assert, afterEach } from 'vitest';
import { Window } from 'happy-dom';
import { onScrollBottom, onScrollTop } from '@/scripts/scroll';
describe('Scroll', () => {
describe('onScrollTop', () => {
test('Initial onScrollTop callback for connected elements', () => {
const { document } = new Window();
const div = document.createElement('div');
assert.strictEqual(div.scrollTop, 0);
document.body.append(div);
let called = false;
onScrollTop(div as any as HTMLElement, () => called = true);
assert.ok(called);
});
test('No onScrollTop callback for disconnected elements', () => {
const { document } = new Window();
const div = document.createElement('div');
assert.strictEqual(div.scrollTop, 0);
let called = false;
onScrollTop(div as any as HTMLElement, () => called = true);
assert.ok(!called);
});
});
describe('onScrollBottom', () => {
test('Initial onScrollBottom callback for connected elements', () => {
const { document } = new Window();
const div = document.createElement('div');
assert.strictEqual(div.scrollTop, 0);
(div as any).scrollHeight = 100; // happy-dom has no scrollHeight
document.body.append(div);
let called = false;
onScrollBottom(div as any as HTMLElement, () => called = true);
assert.ok(called);
});
test('No onScrollBottom callback for disconnected elements', () => {
const { document } = new Window();
const div = document.createElement('div');
assert.strictEqual(div.scrollTop, 0);
(div as any).scrollHeight = 100; // happy-dom has no scrollHeight
let called = false;
onScrollBottom(div as any as HTMLElement, () => called = true);
assert.ok(!called);
});
});
});