1
0
mirror of https://github.com/whippyshou/mastodon synced 2024-12-17 16:18:29 +09:00
whippy-edition/spec/controllers/api/v1/timelines
Claire e38fc319dc
Refactor and improve tests (#17386)
* Change account and user fabricators to simplify and improve tests

- `Fabricate(:account)` implicitly fabricates an associated `user` if
  no `domain` attribute is given (an account with `domain: nil` is
  considered a local account, but no user record was created), unless
  `user: nil` is passed
- `Fabricate(:account, user: Fabricate(:user))` should still be possible
  but is discouraged.

* Fix and refactor tests

- avoid passing unneeded attributes to `Fabricate(:user)` or
  `Fabricate(:account)`
- avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other
  way around
- prefer `Fabricate(:user, account_attributes: …)` to
  `Fabricate(:user, account: Fabricate(:account, …)`
- also, some tests were using remote accounts with local user records, which is
  not representative of production code.
2022-01-28 00:46:42 +01:00
..
home_controller_spec.rb Refactor and improve tests (#17386) 2022-01-28 00:46:42 +01:00
list_controller_spec.rb Refactor and improve tests (#17386) 2022-01-28 00:46:42 +01:00
public_controller_spec.rb Refactor and improve tests (#17386) 2022-01-28 00:46:42 +01:00
tag_controller_spec.rb Refactor and improve tests (#17386) 2022-01-28 00:46:42 +01:00