mirror of
https://github.com/whippyshou/mastodon
synced 2024-11-24 15:16:26 +09:00
555c4e11ba
* Add validations to admin settings - Validate correct HTML markup - Validate presence of contact username & e-mail - Validate that all usernames are valid - Validate that enums have expected values * Fix code style issue * Fix tests
72 lines
2.1 KiB
Ruby
72 lines
2.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe Admin::SettingsController, type: :controller do
|
|
render_views
|
|
|
|
describe 'When signed in as an admin' do
|
|
before do
|
|
sign_in Fabricate(:user, admin: true), scope: :user
|
|
end
|
|
|
|
describe 'GET #edit' do
|
|
it 'returns http success' do
|
|
get :edit
|
|
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
end
|
|
|
|
describe 'PUT #update' do
|
|
before do
|
|
allow_any_instance_of(Form::AdminSettings).to receive(:valid?).and_return(true)
|
|
end
|
|
|
|
describe 'for a record that doesnt exist' do
|
|
around do |example|
|
|
before = Setting.site_extended_description
|
|
Setting.site_extended_description = nil
|
|
example.run
|
|
Setting.site_extended_description = before
|
|
Setting.new_setting_key = nil
|
|
end
|
|
|
|
it 'cannot create a setting value for a non-admin key' do
|
|
expect(Setting.new_setting_key).to be_blank
|
|
|
|
patch :update, params: { form_admin_settings: { new_setting_key: 'New key value' } }
|
|
|
|
expect(response).to redirect_to(edit_admin_settings_path)
|
|
expect(Setting.new_setting_key).to be_nil
|
|
end
|
|
|
|
it 'creates a settings value that didnt exist before for eligible key' do
|
|
expect(Setting.site_extended_description).to be_blank
|
|
|
|
patch :update, params: { form_admin_settings: { site_extended_description: 'New key value' } }
|
|
|
|
expect(response).to redirect_to(edit_admin_settings_path)
|
|
expect(Setting.site_extended_description).to eq 'New key value'
|
|
end
|
|
end
|
|
|
|
context do
|
|
around do |example|
|
|
site_title = Setting.site_title
|
|
example.run
|
|
Setting.site_title = site_title
|
|
end
|
|
|
|
it 'updates a settings value' do
|
|
Setting.site_title = 'Original'
|
|
patch :update, params: { form_admin_settings: { site_title: 'New title' } }
|
|
|
|
expect(response).to redirect_to(edit_admin_settings_path)
|
|
expect(Setting.site_title).to eq 'New title'
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|