mirror of
https://github.com/whippyshou/mastodon
synced 2024-12-02 00:38:27 +09:00
e38fc319dc
* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
95 lines
2.2 KiB
Ruby
95 lines
2.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
require 'pundit/rspec'
|
|
|
|
RSpec.describe InvitePolicy do
|
|
let(:subject) { described_class }
|
|
let(:admin) { Fabricate(:user, admin: true).account }
|
|
let(:john) { Fabricate(:account) }
|
|
|
|
permissions :index? do
|
|
context 'staff?' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin, Invite)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :create? do
|
|
context 'min_required_role?' do
|
|
it 'permits' do
|
|
allow_any_instance_of(described_class).to receive(:min_required_role?) { true }
|
|
expect(subject).to permit(john, Invite)
|
|
end
|
|
end
|
|
|
|
context 'not min_required_role?' do
|
|
it 'denies' do
|
|
allow_any_instance_of(described_class).to receive(:min_required_role?) { false }
|
|
expect(subject).to_not permit(john, Invite)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :deactivate_all? do
|
|
context 'admin?' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin, Invite)
|
|
end
|
|
end
|
|
|
|
context 'not admin?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john, Invite)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :destroy? do
|
|
context 'owner?' do
|
|
it 'permits' do
|
|
expect(subject).to permit(john, Fabricate(:invite, user: john.user))
|
|
end
|
|
end
|
|
|
|
context 'not owner?' do
|
|
context 'Setting.min_invite_role == "admin"' do
|
|
before do
|
|
Setting.min_invite_role = 'admin'
|
|
end
|
|
|
|
context 'admin?' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin, Fabricate(:invite))
|
|
end
|
|
end
|
|
|
|
context 'not admin?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john, Fabricate(:invite))
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'Setting.min_invite_role != "admin"' do
|
|
before do
|
|
Setting.min_invite_role = 'else'
|
|
end
|
|
|
|
context 'staff?' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin, Fabricate(:invite))
|
|
end
|
|
end
|
|
|
|
context 'not staff?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john, Fabricate(:invite))
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|