mirror of
https://github.com/whippyshou/mastodon
synced 2024-12-15 15:18:24 +09:00
e38fc319dc
* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
53 lines
1.3 KiB
Ruby
53 lines
1.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
require 'pundit/rspec'
|
|
|
|
RSpec.describe AccountModerationNotePolicy do
|
|
let(:subject) { described_class }
|
|
let(:admin) { Fabricate(:user, admin: true).account }
|
|
let(:john) { Fabricate(:account) }
|
|
|
|
permissions :create? do
|
|
context 'staff' do
|
|
it 'grants to create' do
|
|
expect(subject).to permit(admin, AccountModerationNotePolicy)
|
|
end
|
|
end
|
|
|
|
context 'not staff' do
|
|
it 'denies to create' do
|
|
expect(subject).to_not permit(john, AccountModerationNotePolicy)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :destroy? do
|
|
let(:account_moderation_note) do
|
|
Fabricate(:account_moderation_note,
|
|
account: john,
|
|
target_account: Fabricate(:account))
|
|
end
|
|
|
|
context 'admin' do
|
|
it 'grants to destroy' do
|
|
expect(subject).to permit(admin, AccountModerationNotePolicy)
|
|
end
|
|
end
|
|
|
|
context 'owner' do
|
|
it 'grants to destroy' do
|
|
expect(subject).to permit(john, account_moderation_note)
|
|
end
|
|
end
|
|
|
|
context 'neither admin nor owner' do
|
|
let(:kevin) { Fabricate(:account) }
|
|
|
|
it 'denies to destroy' do
|
|
expect(subject).to_not permit(kevin, account_moderation_note)
|
|
end
|
|
end
|
|
end
|
|
end
|