mirror of
https://github.com/whippyshou/mastodon
synced 2024-12-05 10:18:39 +09:00
5abdc77c80
* Add <ostatus:conversation /> tag to Atom input/output Only uses ref attribute (not href) because href would be the alternate link that's always included also. Creates new conversation for every non-reply status. Carries over conversation for every reply. Keeps remote URIs verbatim, generates local URIs on the fly like the rest of them. * Fix conversation migration * More spec coverage for status before_create * Prevent n+1 query when generating Atom with the new conversations * Improve code style * Remove redundant local variable
400 lines
12 KiB
Ruby
400 lines
12 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Status, type: :model do
|
|
let(:alice) { Fabricate(:account, username: 'alice') }
|
|
let(:bob) { Fabricate(:account, username: 'bob') }
|
|
let(:other) { Fabricate(:status, account: bob, text: 'Skulls for the skull god! The enemy\'s gates are sideways!')}
|
|
|
|
subject { Fabricate(:status, account: alice) }
|
|
|
|
describe '#local?' do
|
|
it 'returns true when no remote URI is set' do
|
|
expect(subject.local?).to be true
|
|
end
|
|
|
|
it 'returns false if a remote URI is set' do
|
|
subject.uri = 'a'
|
|
expect(subject.local?).to be false
|
|
end
|
|
end
|
|
|
|
describe '#reblog?' do
|
|
it 'returns true when the status reblogs another status' do
|
|
subject.reblog = other
|
|
expect(subject.reblog?).to be true
|
|
end
|
|
|
|
it 'returns false if the status is self-contained' do
|
|
expect(subject.reblog?).to be false
|
|
end
|
|
end
|
|
|
|
describe '#reply?' do
|
|
it 'returns true if the status references another' do
|
|
subject.thread = other
|
|
expect(subject.reply?).to be true
|
|
end
|
|
|
|
it 'returns false if the status is self-contained' do
|
|
expect(subject.reply?).to be false
|
|
end
|
|
end
|
|
|
|
describe '#verb' do
|
|
it 'is always post' do
|
|
expect(subject.verb).to be :post
|
|
end
|
|
end
|
|
|
|
describe '#object_type' do
|
|
it 'is note when the status is self-contained' do
|
|
expect(subject.object_type).to be :note
|
|
end
|
|
|
|
it 'is comment when the status replies to another' do
|
|
subject.thread = other
|
|
expect(subject.object_type).to be :comment
|
|
end
|
|
end
|
|
|
|
describe '#title' do
|
|
it 'is a shorter version of the content' do
|
|
expect(subject.title).to be_a String
|
|
end
|
|
end
|
|
|
|
describe '#content' do
|
|
it 'returns the text of the status if it is not a reblog' do
|
|
expect(subject.content).to eql subject.text
|
|
end
|
|
|
|
it 'returns the text of the reblogged status' do
|
|
subject.reblog = other
|
|
expect(subject.content).to eql other.text
|
|
end
|
|
end
|
|
|
|
describe '#target' do
|
|
it 'returns nil if the status is self-contained' do
|
|
expect(subject.target).to be_nil
|
|
end
|
|
|
|
it 'returns nil if the status is a reply' do
|
|
subject.thread = other
|
|
expect(subject.target).to be_nil
|
|
end
|
|
|
|
it 'returns the reblogged status' do
|
|
subject.reblog = other
|
|
expect(subject.target).to eq other
|
|
end
|
|
end
|
|
|
|
describe '#reblogs_count' do
|
|
it 'is the number of reblogs' do
|
|
Fabricate(:status, account: bob, reblog: subject)
|
|
Fabricate(:status, account: alice, reblog: subject)
|
|
|
|
expect(subject.reblogs_count).to eq 2
|
|
end
|
|
end
|
|
|
|
describe '#favourites_count' do
|
|
it 'is the number of favorites' do
|
|
Fabricate(:favourite, account: bob, status: subject)
|
|
Fabricate(:favourite, account: alice, status: subject)
|
|
|
|
expect(subject.favourites_count).to eq 2
|
|
end
|
|
end
|
|
|
|
describe '#proper' do
|
|
it 'is itself for original statuses' do
|
|
expect(subject.proper).to eq subject
|
|
end
|
|
|
|
it 'is the source status for reblogs' do
|
|
subject.reblog = other
|
|
expect(subject.proper).to eq other
|
|
end
|
|
end
|
|
|
|
describe '#permitted?' do
|
|
it 'returns true when direct and account is viewer' do
|
|
subject.visibility = :direct
|
|
expect(subject.permitted?(subject.account)).to be true
|
|
end
|
|
|
|
it 'returns true when direct and viewer is mentioned' do
|
|
subject.visibility = :direct
|
|
subject.mentions = [Fabricate(:mention, account: alice)]
|
|
|
|
expect(subject.permitted?(alice)).to be true
|
|
end
|
|
|
|
it 'returns false when direct and viewer is not mentioned' do
|
|
viewer = Fabricate(:account)
|
|
subject.visibility = :direct
|
|
|
|
expect(subject.permitted?(viewer)).to be false
|
|
end
|
|
|
|
it 'returns true when private and account is viewer' do
|
|
subject.visibility = :direct
|
|
expect(subject.permitted?(subject.account)).to be true
|
|
end
|
|
|
|
it 'returns true when private and account is following viewer' do
|
|
follow = Fabricate(:follow)
|
|
subject.visibility = :private
|
|
subject.account = follow.target_account
|
|
|
|
expect(subject.permitted?(follow.account)).to be true
|
|
end
|
|
|
|
it 'returns true when private and viewer is mentioned' do
|
|
subject.visibility = :private
|
|
subject.mentions = [Fabricate(:mention, account: alice)]
|
|
|
|
expect(subject.permitted?(alice)).to be true
|
|
end
|
|
|
|
it 'returns false when private and viewer is not mentioned or followed' do
|
|
viewer = Fabricate(:account)
|
|
subject.visibility = :private
|
|
|
|
expect(subject.permitted?(viewer)).to be false
|
|
end
|
|
|
|
it 'returns true when no viewer' do
|
|
expect(subject.permitted?).to be true
|
|
end
|
|
|
|
it 'returns false when viewer is blocked' do
|
|
block = Fabricate(:block)
|
|
subject.visibility = :private
|
|
subject.account = block.target_account
|
|
|
|
expect(subject.permitted?(block.account)).to be false
|
|
end
|
|
end
|
|
|
|
describe '#filter_from_context?' do
|
|
pending
|
|
end
|
|
|
|
describe '.local_only' do
|
|
it 'returns only statuses from local accounts' do
|
|
local_account = Fabricate(:account, domain: nil)
|
|
remote_account = Fabricate(:account, domain: 'test.com')
|
|
local_status = Fabricate(:status, account: local_account)
|
|
remote_status = Fabricate(:status, account: remote_account)
|
|
|
|
results = described_class.local_only
|
|
expect(results).to include(local_status)
|
|
expect(results).not_to include(remote_status)
|
|
end
|
|
end
|
|
|
|
describe '.as_home_timeline' do
|
|
before do
|
|
account = Fabricate(:account)
|
|
followed = Fabricate(:account)
|
|
not_followed = Fabricate(:account)
|
|
Fabricate(:follow, account: account, target_account: followed)
|
|
|
|
@self_status = Fabricate(:status, account: account)
|
|
@followed_status = Fabricate(:status, account: followed)
|
|
@not_followed_status = Fabricate(:status, account: not_followed)
|
|
|
|
@results = Status.as_home_timeline(account)
|
|
end
|
|
|
|
it 'includes statuses from self' do
|
|
expect(@results).to include(@self_status)
|
|
end
|
|
|
|
it 'includes statuses from followed' do
|
|
expect(@results).to include(@followed_status)
|
|
end
|
|
|
|
it 'does not include statuses from non-followed' do
|
|
expect(@results).not_to include(@not_followed_status)
|
|
end
|
|
end
|
|
|
|
describe '.as_public_timeline' do
|
|
it 'only includes statuses with public visibility' do
|
|
public_status = Fabricate(:status, visibility: :public)
|
|
private_status = Fabricate(:status, visibility: :private)
|
|
|
|
results = Status.as_public_timeline
|
|
expect(results).to include(public_status)
|
|
expect(results).not_to include(private_status)
|
|
end
|
|
|
|
it 'does not include replies' do
|
|
status = Fabricate(:status)
|
|
reply = Fabricate(:status, in_reply_to_id: status.id)
|
|
|
|
results = Status.as_public_timeline
|
|
expect(results).to include(status)
|
|
expect(results).not_to include(reply)
|
|
end
|
|
|
|
it 'does not include boosts' do
|
|
status = Fabricate(:status)
|
|
boost = Fabricate(:status, reblog_of_id: status.id)
|
|
|
|
results = Status.as_public_timeline
|
|
expect(results).to include(status)
|
|
expect(results).not_to include(boost)
|
|
end
|
|
|
|
it 'filters out silenced accounts' do
|
|
account = Fabricate(:account)
|
|
silenced_account = Fabricate(:account, silenced: true)
|
|
status = Fabricate(:status, account: account)
|
|
silenced_status = Fabricate(:status, account: silenced_account)
|
|
|
|
results = Status.as_public_timeline
|
|
expect(results).to include(status)
|
|
expect(results).not_to include(silenced_status)
|
|
end
|
|
|
|
context 'with a local_only option set' do
|
|
it 'does not include remote instances statuses' do
|
|
local_account = Fabricate(:account, domain: nil)
|
|
remote_account = Fabricate(:account, domain: 'test.com')
|
|
local_status = Fabricate(:status, account: local_account)
|
|
remote_status = Fabricate(:status, account: remote_account)
|
|
|
|
results = Status.as_public_timeline(nil, true)
|
|
expect(results).to include(local_status)
|
|
expect(results).not_to include(remote_status)
|
|
end
|
|
end
|
|
|
|
describe 'with an account passed in' do
|
|
before do
|
|
@account = Fabricate(:account)
|
|
end
|
|
|
|
it 'excludes statuses from accounts blocked by the account' do
|
|
blocked = Fabricate(:account)
|
|
Fabricate(:block, account: @account, target_account: blocked)
|
|
blocked_status = Fabricate(:status, account: blocked)
|
|
|
|
results = Status.as_public_timeline(@account)
|
|
expect(results).not_to include(blocked_status)
|
|
end
|
|
|
|
it 'excludes statuses from accounts who have blocked the account' do
|
|
blocked = Fabricate(:account)
|
|
Fabricate(:block, account: blocked, target_account: @account)
|
|
blocked_status = Fabricate(:status, account: blocked)
|
|
|
|
results = Status.as_public_timeline(@account)
|
|
expect(results).not_to include(blocked_status)
|
|
end
|
|
|
|
it 'excludes statuses from accounts muted by the account' do
|
|
muted = Fabricate(:account)
|
|
Fabricate(:mute, account: @account, target_account: muted)
|
|
muted_status = Fabricate(:status, account: muted)
|
|
|
|
results = Status.as_public_timeline(@account)
|
|
expect(results).not_to include(muted_status)
|
|
end
|
|
|
|
context 'with language preferences' do
|
|
it 'excludes statuses in languages not allowed by the account user' do
|
|
user = Fabricate(:user, allowed_languages: [:en, :es])
|
|
@account.update(user: user)
|
|
en_status = Fabricate(:status, language: 'en')
|
|
es_status = Fabricate(:status, language: 'es')
|
|
fr_status = Fabricate(:status, language: 'fr')
|
|
|
|
results = Status.as_public_timeline(@account)
|
|
expect(results).to include(en_status)
|
|
expect(results).to include(es_status)
|
|
expect(results).not_to include(fr_status)
|
|
end
|
|
|
|
it 'includes all languages when user does not have a setting' do
|
|
user = Fabricate(:user, allowed_languages: [])
|
|
@account.update(user: user)
|
|
|
|
en_status = Fabricate(:status, language: 'en')
|
|
es_status = Fabricate(:status, language: 'es')
|
|
|
|
results = Status.as_public_timeline(@account)
|
|
expect(results).to include(en_status)
|
|
expect(results).to include(es_status)
|
|
end
|
|
|
|
it 'includes all languages when account does not have a user' do
|
|
expect(@account.user).to be_nil
|
|
en_status = Fabricate(:status, language: 'en')
|
|
es_status = Fabricate(:status, language: 'es')
|
|
|
|
results = Status.as_public_timeline(@account)
|
|
expect(results).to include(en_status)
|
|
expect(results).to include(es_status)
|
|
end
|
|
end
|
|
|
|
context 'where that account is silenced' do
|
|
it 'includes statuses from other accounts that are silenced' do
|
|
@account.update(silenced: true)
|
|
other_silenced_account = Fabricate(:account, silenced: true)
|
|
other_status = Fabricate(:status, account: other_silenced_account)
|
|
|
|
results = Status.as_public_timeline(@account)
|
|
expect(results).to include(other_status)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '.as_tag_timeline' do
|
|
it 'includes statuses with a tag' do
|
|
tag = Fabricate(:tag)
|
|
status = Fabricate(:status, tags: [tag])
|
|
other = Fabricate(:status)
|
|
|
|
results = Status.as_tag_timeline(tag)
|
|
expect(results).to include(status)
|
|
expect(results).not_to include(other)
|
|
end
|
|
|
|
it 'allows replies to be included' do
|
|
original = Fabricate(:status)
|
|
tag = Fabricate(:tag)
|
|
status = Fabricate(:status, tags: [tag], in_reply_to_id: original.id)
|
|
|
|
results = Status.as_tag_timeline(tag)
|
|
expect(results).to include(status)
|
|
end
|
|
end
|
|
|
|
describe 'before_create' do
|
|
it 'sets account being replied to correctly over intermediary nodes' do
|
|
first_status = Fabricate(:status, account: bob)
|
|
intermediary = Fabricate(:status, thread: first_status, account: alice)
|
|
final = Fabricate(:status, thread: intermediary, account: alice)
|
|
|
|
expect(final.in_reply_to_account_id).to eq bob.id
|
|
end
|
|
|
|
it 'creates new conversation for stand-alone status' do
|
|
expect(Status.create(account: alice, text: 'First').conversation_id).to_not be_nil
|
|
end
|
|
|
|
it 'keeps conversation of parent node' do
|
|
parent = Fabricate(:status, text: 'First')
|
|
expect(Status.create(account: alice, thread: parent, text: 'Response').conversation_id).to eq parent.conversation_id
|
|
end
|
|
end
|
|
end
|