mirror/misskey
1
0
Fork 0
mirror of https://github.com/misskey-dev/misskey synced 2024-12-01 08:18:51 +09:00
Code

Fix bug

Browse Source
This commit is contained in:
syuilo 2018-06-23 19:16:50 +09:00
parent 5ff59b3339
commit 509cdae832
2 changed files with 23 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/remote/activitypub/models/person.ts
View File

@ -47,16 +47,28 @@ export async function createPerson(value: any, resolver?: Resolver): Promise<IUs
const object = await resolver.resolve(value) as any;
if (
object == null ||
object.type !== 'Person' ||
typeof object.preferredUsername !== 'string' ||
typeof object.inbox !== 'string' ||
!validateUsername(object.preferredUsername) ||
!isValidName(object.name == '' ? null : object.name)
) {
log(`invalid person: ${JSON.stringify(object, null, 2)}`);
throw new Error('invalid person');
if (object == null) {
throw new Error('invalid person: object is null');
}
if (object.type != 'Person' && object.type != 'Service') {
throw new Error('invalid person: object is not a person or service');
}
if (typeof object.preferredUsername !== 'string') {
throw new Error('invalid person: preferredUsername is not a string');
}
if (typeof object.inbox !== 'string') {
throw new Error('invalid person: inbox is not a string');
}
if (!validateUsername(object.preferredUsername)) {
throw new Error('invalid person: invalid username');
}
if (!isValidName(object.name == '' ? null : object.name)) {
throw new Error('invalid person: invalid name');
}
const person: IPerson = object;

2
src/remote/activitypub/renderer/person.ts
View File

@ -7,7 +7,7 @@ export default (user: ILocalUser) => {
const id = `${config.url}/users/${user._id}`;
return {
type: 'Person',
type: user.isBot ? 'Service' : 'Person',
id,
inbox: `${id}/inbox`,
outbox: `${id}/outbox`,