mirror of
https://github.com/mastodon/mastodon
synced 2024-12-01 08:18:22 +09:00
9a19227f17
* Fix Delete and Create-related locks expiring too fast Fixes #16238 By default, RedisLock expires after 10 seconds, which may not be enough to process statuses, especially when those have attached media files. This commit extends those 10 seconds to 15 minutes, which should be plenty enough to handle any status, while being short enough to not waste many sidekiq job retries in the exceedingly rare case in which a sidekiq process would crash when processing a `Create` or `Delete`. * Fix other RedisLock autorelease durations Fixes #15645 - things that only perform a few simple database queries (e.g. finding and saving a record) have been left unchanged, so they'll still use the default 10s duration - things that perform significantly more complex database queries have been changed to a 5 minutes timeout - things that perform multiple HTTP queries have been changed to a 15 minutes timeout
147 lines
4.7 KiB
Ruby
147 lines
4.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class RemoveStatusService < BaseService
|
|
include Redisable
|
|
include Payloadable
|
|
|
|
# Delete a status
|
|
# @param [Status] status
|
|
# @param [Hash] options
|
|
# @option [Boolean] :redraft
|
|
# @option [Boolean] :immediate
|
|
# @option [Boolean] :original_removed
|
|
def call(status, **options)
|
|
@payload = Oj.dump(event: :delete, payload: status.id.to_s)
|
|
@status = status
|
|
@account = status.account
|
|
@options = options
|
|
|
|
@status.discard
|
|
|
|
RedisLock.acquire(lock_options) do |lock|
|
|
if lock.acquired?
|
|
remove_from_self if @account.local?
|
|
remove_from_followers
|
|
remove_from_lists
|
|
|
|
# There is no reason to send out Undo activities when the
|
|
# cause is that the original object has been removed, since
|
|
# original object being removed implicitly removes reblogs
|
|
# of it. The Delete activity of the original is forwarded
|
|
# separately.
|
|
remove_from_remote_reach if @account.local? && !@options[:original_removed]
|
|
|
|
# Since reblogs don't mention anyone, don't get reblogged,
|
|
# favourited and don't contain their own media attachments
|
|
# or hashtags, this can be skipped
|
|
unless @status.reblog?
|
|
remove_from_mentions
|
|
remove_reblogs
|
|
remove_from_hashtags
|
|
remove_from_public
|
|
remove_from_media if @status.media_attachments.any?
|
|
remove_media
|
|
end
|
|
|
|
@status.destroy! if @options[:immediate] || !@status.reported?
|
|
else
|
|
raise Mastodon::RaceConditionError
|
|
end
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def remove_from_self
|
|
FeedManager.instance.unpush_from_home(@account, @status)
|
|
end
|
|
|
|
def remove_from_followers
|
|
@account.followers_for_local_distribution.reorder(nil).find_each do |follower|
|
|
FeedManager.instance.unpush_from_home(follower, @status)
|
|
end
|
|
end
|
|
|
|
def remove_from_lists
|
|
@account.lists_for_local_distribution.select(:id, :account_id).reorder(nil).find_each do |list|
|
|
FeedManager.instance.unpush_from_list(list, @status)
|
|
end
|
|
end
|
|
|
|
def remove_from_mentions
|
|
# For limited visibility statuses, the mentions that determine
|
|
# who receives them in their home feed are a subset of followers
|
|
# and therefore the delete is already handled by sending it to all
|
|
# followers. Here we send a delete to actively mentioned accounts
|
|
# that may not follow the account
|
|
|
|
@status.active_mentions.find_each do |mention|
|
|
redis.publish("timeline:#{mention.account_id}", @payload)
|
|
end
|
|
end
|
|
|
|
def remove_from_remote_reach
|
|
# Followers, relays, people who got mentioned in the status,
|
|
# or who reblogged it from someone else might not follow
|
|
# the author and wouldn't normally receive the delete
|
|
# notification - so here, we explicitly send it to them
|
|
|
|
status_reach_finder = StatusReachFinder.new(@status)
|
|
|
|
ActivityPub::DeliveryWorker.push_bulk(status_reach_finder.inboxes) do |inbox_url|
|
|
[signed_activity_json, @account.id, inbox_url]
|
|
end
|
|
end
|
|
|
|
def signed_activity_json
|
|
@signed_activity_json ||= Oj.dump(serialize_payload(@status, @status.reblog? ? ActivityPub::UndoAnnounceSerializer : ActivityPub::DeleteSerializer, signer: @account))
|
|
end
|
|
|
|
def remove_reblogs
|
|
# We delete reblogs of the status before the original status,
|
|
# because once original status is gone, reblogs will disappear
|
|
# without us being able to do all the fancy stuff
|
|
|
|
@status.reblogs.includes(:account).find_each do |reblog|
|
|
RemoveStatusService.new.call(reblog, original_removed: true)
|
|
end
|
|
end
|
|
|
|
def remove_from_hashtags
|
|
@account.featured_tags.where(tag_id: @status.tags.map(&:id)).each do |featured_tag|
|
|
featured_tag.decrement(@status.id)
|
|
end
|
|
|
|
return unless @status.public_visibility?
|
|
|
|
@status.tags.map(&:name).each do |hashtag|
|
|
redis.publish("timeline:hashtag:#{hashtag.mb_chars.downcase}", @payload)
|
|
redis.publish("timeline:hashtag:#{hashtag.mb_chars.downcase}:local", @payload) if @status.local?
|
|
end
|
|
end
|
|
|
|
def remove_from_public
|
|
return unless @status.public_visibility?
|
|
|
|
redis.publish('timeline:public', @payload)
|
|
redis.publish(@status.local? ? 'timeline:public:local' : 'timeline:public:remote', @payload)
|
|
end
|
|
|
|
def remove_from_media
|
|
return unless @status.public_visibility?
|
|
|
|
redis.publish('timeline:public:media', @payload)
|
|
redis.publish(@status.local? ? 'timeline:public:local:media' : 'timeline:public:remote:media', @payload)
|
|
end
|
|
|
|
def remove_media
|
|
return if @options[:redraft] || (!@options[:immediate] && @status.reported?)
|
|
|
|
@status.media_attachments.destroy_all
|
|
end
|
|
|
|
def lock_options
|
|
{ redis: Redis.current, key: "distribute:#{@status.id}", autorelease: 5.minutes.seconds }
|
|
end
|
|
end
|