2023-02-22 09:55:31 +09:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2017-04-15 10:17:07 +09:00
|
|
|
require 'rails_helper'
|
|
|
|
|
2024-09-04 14:12:25 +09:00
|
|
|
RSpec.describe AccountSearchService do
|
2019-08-16 08:24:03 +09:00
|
|
|
describe '#call' do
|
|
|
|
context 'with a query to ignore' do
|
2017-04-15 10:17:07 +09:00
|
|
|
it 'returns empty array for missing query' do
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 23:21:36 +09:00
|
|
|
results = subject.call('', nil, limit: 10)
|
2017-04-15 10:17:07 +09:00
|
|
|
|
|
|
|
expect(results).to eq []
|
|
|
|
end
|
|
|
|
|
2017-04-25 11:44:43 +09:00
|
|
|
it 'returns empty array for limit zero' do
|
|
|
|
Fabricate(:account, username: 'match')
|
2019-08-16 08:24:03 +09:00
|
|
|
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 23:21:36 +09:00
|
|
|
results = subject.call('match', nil, limit: 0)
|
2017-04-25 11:44:43 +09:00
|
|
|
|
2017-04-15 10:17:07 +09:00
|
|
|
expect(results).to eq []
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-04 12:49:08 +09:00
|
|
|
context 'when searching for a simple term that is not an exact match' do
|
2017-04-15 10:17:07 +09:00
|
|
|
it 'does not return a nil entry in the array for the exact match' do
|
2019-08-16 08:24:03 +09:00
|
|
|
account = Fabricate(:account, username: 'matchingusername')
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 23:21:36 +09:00
|
|
|
results = subject.call('match', nil, limit: 5)
|
2017-04-15 10:17:07 +09:00
|
|
|
|
2019-08-16 08:24:03 +09:00
|
|
|
expect(results).to eq [account]
|
2017-04-15 10:17:07 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-08-16 08:24:03 +09:00
|
|
|
context 'when there is a local domain' do
|
2017-05-27 07:55:08 +09:00
|
|
|
around do |example|
|
|
|
|
before = Rails.configuration.x.local_domain
|
2019-08-16 08:24:03 +09:00
|
|
|
|
2017-05-27 07:55:08 +09:00
|
|
|
example.run
|
2019-08-16 08:24:03 +09:00
|
|
|
|
2017-05-27 07:55:08 +09:00
|
|
|
Rails.configuration.x.local_domain = before
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns exact match first' do
|
|
|
|
remote = Fabricate(:account, username: 'a', domain: 'remote', display_name: 'e')
|
|
|
|
remote_too = Fabricate(:account, username: 'b', domain: 'remote', display_name: 'e')
|
2019-08-16 08:24:03 +09:00
|
|
|
exact = Fabricate(:account, username: 'e')
|
|
|
|
|
2017-05-27 07:55:08 +09:00
|
|
|
Rails.configuration.x.local_domain = 'example.com'
|
|
|
|
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 23:21:36 +09:00
|
|
|
results = subject.call('e@example.com', nil, limit: 2)
|
2019-08-16 08:24:03 +09:00
|
|
|
|
2017-05-27 07:55:08 +09:00
|
|
|
expect(results).to eq([exact, remote]).or eq([exact, remote_too])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-08-16 08:24:03 +09:00
|
|
|
context 'when there is a domain but no exact match' do
|
2017-04-15 10:17:07 +09:00
|
|
|
it 'follows the remote account when resolve is true' do
|
2023-06-22 21:55:22 +09:00
|
|
|
service = instance_double(ResolveAccountService, call: nil)
|
2018-01-22 22:25:09 +09:00
|
|
|
allow(ResolveAccountService).to receive(:new).and_return(service)
|
2017-04-15 10:17:07 +09:00
|
|
|
|
2023-10-19 23:55:06 +09:00
|
|
|
subject.call('newuser@remote.com', nil, limit: 10, resolve: true)
|
2017-04-15 10:17:07 +09:00
|
|
|
expect(service).to have_received(:call).with('newuser@remote.com')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not follow the remote account when resolve is false' do
|
2023-06-22 21:55:22 +09:00
|
|
|
service = instance_double(ResolveAccountService, call: nil)
|
2018-01-22 22:25:09 +09:00
|
|
|
allow(ResolveAccountService).to receive(:new).and_return(service)
|
2017-04-15 10:17:07 +09:00
|
|
|
|
2023-10-19 23:55:06 +09:00
|
|
|
subject.call('newuser@remote.com', nil, limit: 10, resolve: false)
|
2023-02-20 10:33:27 +09:00
|
|
|
expect(service).to_not have_received(:call)
|
2017-04-15 10:17:07 +09:00
|
|
|
end
|
|
|
|
end
|
2018-04-24 04:27:18 +09:00
|
|
|
|
2019-08-16 08:24:03 +09:00
|
|
|
it 'returns the fuzzy match first, and does not return suspended exacts' do
|
|
|
|
partial = Fabricate(:account, username: 'exactness')
|
2023-10-19 23:55:06 +09:00
|
|
|
Fabricate(:account, username: 'exact', suspended: true)
|
2019-08-16 08:24:03 +09:00
|
|
|
results = subject.call('exact', nil, limit: 10)
|
2018-04-24 04:27:18 +09:00
|
|
|
|
2019-08-16 08:24:03 +09:00
|
|
|
expect(results.size).to eq 1
|
|
|
|
expect(results).to eq [partial]
|
|
|
|
end
|
2018-04-24 04:27:18 +09:00
|
|
|
|
2023-02-19 07:38:14 +09:00
|
|
|
it 'does not return suspended remote accounts' do
|
2023-10-19 23:55:06 +09:00
|
|
|
Fabricate(:account, username: 'a', domain: 'remote', display_name: 'e', suspended: true)
|
2019-08-16 08:24:03 +09:00
|
|
|
results = subject.call('a@example.com', nil, limit: 2)
|
2018-04-24 04:27:18 +09:00
|
|
|
|
2019-08-16 08:24:03 +09:00
|
|
|
expect(results.size).to eq 0
|
|
|
|
expect(results).to eq []
|
2018-04-24 04:27:18 +09:00
|
|
|
end
|
2017-04-15 10:17:07 +09:00
|
|
|
end
|
|
|
|
end
|