Commit Graph

20812 Commits

Author SHA1 Message Date
Andreas Nedbal
f0b27fa22b Extract commonly used test logic to commands (#8767)
* meta(tests): enable workflows to run in branch

* feat(tests): move commonly used logic to Cypress commands

* chore(tests): replace more code with commands

* meta(tests): disable workflows to run in branch
2022-05-31 17:57:01 +09:00
MeiMei
857b9cab2b Fix Cannot find module issue (#8770)
* Add --force to yarn in the installation script

* CHAGELOG
2022-05-31 17:55:07 +09:00
Johann150
8e296b2398 fix: always remove completed tasks (#8771) 2022-05-31 17:54:02 +09:00
MeiMei
f59e364a85 Fix IP address rate limit (#8758)
* Fix IP address rate limit

* CHANGELOG

* Tune getIpHash
2022-05-31 17:44:22 +09:00
Andreas Nedbal
7261baa7dc chore(meta): label Pull Requests containing tests (#8768) 2022-05-31 11:38:52 +09:00
tamaina
d1a90695a2 chore: fix import tinycolor 2022-05-30 12:09:22 +00:00
tamaina
db26061f90 Merge branch 'develop' of https://github.com/misskey-dev/misskey into develop 2022-05-30 05:53:40 +00:00
tamaina
3d33296741 chore: remove packages/sw/webpack.config.js 2022-05-30 05:53:36 +00:00
Andreas Nedbal
3b0e1037f5 fix(client): import shared ESLint config in client package (#8761) 2022-05-30 11:37:34 +09:00
Johann150
3b970aae8a fix: add missing import
fix #8756
2022-05-29 14:33:42 +02:00
Johann150
47b80744e8 enhance(dev): ask for log snippets 2022-05-29 14:26:29 +02:00
futchitwo
eb3a114027 fix(client): fix popout url (#8494) 2022-05-29 12:21:36 +02:00
Johann150
ec47b46423 refactor: improve code quality (#8751)
* remove unnecessary if

`Array.prototype.some` already returns a boolean so an if to return
true or false is completely unnecessary in this case.

* perf: use count instead of find

When using `count` instead of `findOneBy`, the data is not
unnecessarily loaded.

* remove duplicate null check

The variable is checked for null in the lines above and the function
returns if so. Therefore, it can not be null at this point.

* simplify `getJsonSchema`

Because the assigned value is `null` and the used keys are only
shallow, use of `nestedProperty.set` seems inappropriate. Because the
value is not read, the initial for loop can be replaced by a `for..in`
loop.

Since all keys will be assigned `null`, the condition of the ternary
expression in the nested function will always be true. Therefore the
recursion case will never happen. With this the nested function can be
eliminated.

* remove duplicate condition

The code above already checks `dragging` and returns if it is truthy.
Checking it again later is therefore unnecessary.

To make this more obvious the `return` is removed in favour of using
an if...else construct.

* remove impossible "unknown" time

The `ago` variable will always be a number and all non-negative numbers
are already covered by other cases, the negative case is handled with
`future` so there is no case when `unkown` could be achieved.
2022-05-29 15:15:52 +09:00
tamaina
1fe73d31ad fix(client): Vite related boot mechanism revision (#8753)
* preload app css

* remove salt

* APP_FETCH_FAILED error

* set max-age to 15s
2022-05-29 10:58:54 +09:00
tamaina
86e6126dd7 preload app css (#8752) 2022-05-29 10:57:06 +09:00
Johann150
fef27a1e92 chore: remove unused imports 2022-05-28 21:17:23 +02:00
Johann150
4a8ea6f2d1 fix: validate text is not empty
fix #8747
2022-05-28 17:26:17 +02:00
tamaina
82331575cf refactor: use css module at components/global/loading.vue (#8750)
* refactor: use css module at components/global/loading.vue

* rename class name to "root"
2022-05-29 00:15:32 +09:00
tamaina
6e4cb0d639 Fix theme import (#8749) 2022-05-28 21:59:23 +09:00
Andreas Nedbal
06ea19ed3a feat(tests): add e2e tests for widgets (#8735)
* test(e2e): add baseline for widget tests

* chore(repo): enable test running in branch

* fix(e2e): set viewport for widget tests

* fix(client): add widget identifier classes to widgets

* test(e2e): add memo widget test

* fix(tests): force select value

* fix(tests): force button press for widget addition

* fix(tests): invoke select value differently

* fix(tests): adjust widget submit

* fix(tests): don't explicitly navigate for widget test

* fix(tests): click label to hide select popup

* fix(tests): just click modal background

* fix(tests): adjust modal background selector

* fix(tests): click all modal backgrounds

* feat(e2e): add test for adding timeline widget

* fix(client): add more widget identifier classes

* feat(tests): add method abstraction for test cases

* fix(tests): force-click overlays

* fix(tests): force widget button press

* fix(tests): remove timeout from final widget check

* feat(tests): add widget removal test case

* fix(client): use mk instead of msky as class prefix

* fix(tests): check widgets for existence rather than visibility

* chore(meta): don't run tests for specific feature branch
2022-05-28 14:28:12 +09:00
Kainoa Kanter
ae8d4a0827 Remove require captcha from signin from CHANGELOG (#8748) 2022-05-28 05:49:34 +02:00
Johann150
0738a65a78 enhance: replace signin CAPTCHA with rate limit (#8740)
* enhance: rate limit works without signed in user

* fix: make limit key required for limiter

As before the fallback limiter key will be set from the endpoint name.

* enhance: use limiter for signin

* Revert "CAPTCHA求めるのは2fa認証が無効になっているときだけにした"

This reverts commit 02a43a310f6ad0cc9e9beccc26e51ab5b339e15f.

* Revert "feat: make captcha required when signin to improve security"

This reverts commit b21b0580058c14532ff3f4033e2a9147643bfca6.

* fix undefined reference

* fix: better error message

* enhance: only handle prefix of IPv6
2022-05-28 12:06:47 +09:00
Johann150
9382d11867 enhance: clearly link documentation
fix #8744
2022-05-27 23:21:12 +02:00
Johann150
7a65931b28 fix(docs): correct information for drive upload (#8736) 2022-05-27 22:03:25 +09:00
Johann150
d2ca085a17 fix lints (#8737)
* fix: emits use ev instead of e

* fix: errors use err instead of e

* fix: replace use of data where possible

* fix: events use evt instead of e

* fix: use strict equals

* fix: use emoji instead of e

* fix: vue lints
2022-05-26 22:53:09 +09:00
Johann150
8d49573447 use http-signature module that supports hs2019 (#8635) 2022-05-26 09:12:17 +09:00
syuilo
cb330fef64 update deps 2022-05-25 23:28:56 +09:00
syuilo
74d968585a refactor: use === 2022-05-25 23:19:39 +09:00
Johann150
62ab5b4015 fix: assume remote users are following each other (#8734)
Misskey does not know if two remote users are following each other.
Because ActivityPub actions would otherwise fail on followers only
notes, we have to assume that two remote users are following each other
when an interaction about a remote note occurs.
2022-05-25 23:17:00 +09:00
Johann150
fc25935360 fix: activity widget used wrong variable name 2022-05-25 10:44:04 +02:00
Johann150
0f307475d3 fix: server metrics widget 2022-05-25 10:13:46 +02:00
Johann150
c2ddc5286c refactor: temporary files (#8713)
* simplify temporary files for thumbnails

Because only a single file will be written to the directory, creating a
separate directory seems unnecessary. If only a temporary file is created,
the code from `createTemp` can be reused here as well.

* refactor: deduplicate code for temporary files/directories

To follow the DRY principle, the same code should not be duplicated
across different files. Instead an already existing function is used.

Because temporary directories are also create in multiple locations,
a function for this is also newly added to reduce duplication.

* fix: clean up identicon temp files

The temporary files for identicons are not reused and can be deleted
after they are fully read. This condition is met when the stream is closed
and so the file can be cleaned up using the events API of the stream.

* fix: ensure cleanup is called when download fails

* fix: ensure cleanup is called in error conditions

This covers import/export queue jobs and is mostly just wrapping all
code in a try...finally statement where the finally runs the cleanup.

* fix: use correct type instead of `any`
2022-05-25 16:50:22 +09:00
Andreas Nedbal
7717535b63 Refactor widgets and fix lint issues (#8719)
* fix(client): refactor widgets and fix lint issues

* Apply review suggestions from @Johann150

Co-authored-by: Johann150 <johann@qwertqwefsday.eu>

Co-authored-by: Johann150 <johann@qwertqwefsday.eu>
2022-05-25 16:43:12 +09:00
Andreas Nedbal
37c4d38bd1 refactor(client): refactor admin/other-settings to use Composition API (#8667) 2022-05-25 16:38:18 +09:00
Andreas Nedbal
1a2447d38c Refactor admin/overview to use Composition API (#8674)
* refactor(client): refactor admin/overview to use Composition API

* fix(client): apply review suggestions
2022-05-25 16:37:35 +09:00
Andreas Nedbal
4633b7547e Refactor my-antennas/edit to use Composition API (#8680)
* refactor(client): refactor my-antennas/edit to use Composition API

* fix(client): apply review suggestions
2022-05-25 16:37:15 +09:00
MeiMei
ca95e15345 Supports Unicode Emoji 14.0 (#8699)
* Unicode 14.0 Emoji

* mfm-js@0.22.0

* CHANGELOG

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
2022-05-25 16:35:30 +09:00
Johann150
80a858e779 feat(dev): highlight editing of wrong locales
Highlight PRs that edit locales other than the ja-JP one so the author may see and fix it themselves.
2022-05-24 11:14:00 +02:00
Johann150
d6046c75aa fix: wrong type for isVisibleForMe 2022-05-24 10:12:42 +02:00
Kainoa Kanter
4d7fa4010b Update README.md (#8729) 2022-05-24 08:10:00 +02:00
Johann150
76e226e226 fix(client): wrong scoping breaks 2FA 2022-05-23 22:43:13 +02:00
Andreas Nedbal
ce4a5fe35b fix(client): fix undefined data value on 2FA settings (#8725) 2022-05-23 21:55:06 +02:00
syuilo
30978638c2 chore(dev): tweak text 2022-05-22 14:49:53 +09:00
syuilo
d253ee6f78 Update .mocharc.json 2022-05-21 22:24:57 +09:00
syuilo
5ad66d3ddd lint 2022-05-21 22:21:41 +09:00
syuilo
6adc5a33fe refactor 2022-05-21 22:07:11 +09:00
syuilo
56e3ad8b5b Update utils.ts 2022-05-21 22:07:01 +09:00
syuilo
17e07de117 Update utils.ts 2022-05-21 17:40:43 +09:00
dependabot[bot]
6760df322d chore(deps): bump hosted-git-info from 2.8.8 to 2.8.9 (#8708)
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](https://github.com/npm/hosted-git-info/compare/v2.8.8...v2.8.9)

---
updated-dependencies:
- dependency-name: hosted-git-info
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-21 16:45:42 +09:00
syuilo
39981ed337 Merge branch 'develop' of https://github.com/misskey-dev/misskey into develop 2022-05-21 11:41:43 +09:00