mirror/cherrypick
1
1
Fork 0
mirror of https://github.com/kokonect-link/cherrypick synced 2024-12-15 23:28:20 +09:00
Code

fix connection close logic

Browse Source
This commit is contained in:
syuilo 2021-06-12 23:01:48 +09:00
parent 1d17516aa8
commit 091ef2e240
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -8,7 +8,7 @@
"build": "npm run tsc", "build": "npm run tsc",
"tsc": "tsc", "tsc": "tsc",
"tsd": "tsd", "tsd": "tsd",
"jest": "jest", "jest": "jest --detectOpenHandles",
"test": "npm run jest && npm run tsd" "test": "npm run jest && npm run tsd"
}, },
"repository": { "repository": {

3
src/streaming.ts
View File

@ -255,8 +255,7 @@ export default class Stream extends EventEmitter<StreamEvents> {
*/ */
@autobind @autobind
public close() { public close() {
this.stream.removeEventListener('open', this.onOpen); this.stream.close();
this.stream.removeEventListener('message', this.onMessage);
} }
} }

5
test/streaming.ts
View File

@ -32,12 +32,14 @@ describe('Streaming', () => {
id: 'foo' id: 'foo'
}); });
stream.close();
server.close(); server.close();
}); });
/* TODO
test('useChannel with parameters', async () => { test('useChannel with parameters', async () => {
// TODO
}); });
*/
test('Connection#dispose', async () => { test('Connection#dispose', async () => {
const server = new WS('wss://misskey.test/streaming'); const server = new WS('wss://misskey.test/streaming');
@ -68,6 +70,7 @@ describe('Streaming', () => {
expect(mainChannelReceived.length).toEqual(0); expect(mainChannelReceived.length).toEqual(0);
stream.close();
server.close(); server.close();
}); });