mirror of
https://github.com/funamitech/mastodon
synced 2024-12-15 15:18:30 +09:00
e38fc319dc
* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
112 lines
3.1 KiB
Ruby
112 lines
3.1 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Settings::MigrationsController do
|
|
render_views
|
|
|
|
shared_examples 'authenticate user' do
|
|
it 'redirects to sign_in page' do
|
|
is_expected.to redirect_to new_user_session_path
|
|
end
|
|
end
|
|
|
|
describe 'GET #show' do
|
|
context 'when user is not sign in' do
|
|
subject { get :show }
|
|
|
|
it_behaves_like 'authenticate user'
|
|
end
|
|
|
|
context 'when user is sign in' do
|
|
subject { get :show }
|
|
|
|
let(:user) { Fabricate(:account, moved_to_account: moved_to_account).user }
|
|
|
|
before { sign_in user, scope: :user }
|
|
|
|
context 'when user does not have moved to account' do
|
|
let(:moved_to_account) { nil }
|
|
|
|
it 'renders show page' do
|
|
is_expected.to have_http_status 200
|
|
is_expected.to render_template :show
|
|
end
|
|
end
|
|
|
|
context 'when user has a moved to account' do
|
|
let(:moved_to_account) { Fabricate(:account) }
|
|
|
|
it 'renders show page' do
|
|
is_expected.to have_http_status 200
|
|
is_expected.to render_template :show
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'POST #create' do
|
|
context 'when user is not sign in' do
|
|
subject { post :create }
|
|
|
|
it_behaves_like 'authenticate user'
|
|
end
|
|
|
|
context 'when user is signed in' do
|
|
subject { post :create, params: { account_migration: { acct: acct, current_password: '12345678' } } }
|
|
|
|
let(:user) { Fabricate(:user, password: '12345678') }
|
|
|
|
before { sign_in user, scope: :user }
|
|
|
|
context 'when migration account is changed' do
|
|
let(:acct) { Fabricate(:account, also_known_as: [ActivityPub::TagManager.instance.uri_for(user.account)]) }
|
|
|
|
it 'updates moved to account' do
|
|
is_expected.to redirect_to settings_migration_path
|
|
expect(user.account.reload.moved_to_account_id).to eq acct.id
|
|
end
|
|
end
|
|
|
|
context 'when acct is the current account' do
|
|
let(:acct) { user.account }
|
|
|
|
it 'renders show' do
|
|
is_expected.to render_template :show
|
|
end
|
|
|
|
it 'does not update the moved account' do
|
|
expect(user.account.reload.moved_to_account_id).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'when target account does not reference the account being moved from' do
|
|
let(:acct) { Fabricate(:account, also_known_as: []) }
|
|
|
|
it 'renders show' do
|
|
is_expected.to render_template :show
|
|
end
|
|
|
|
it 'does not update the moved account' do
|
|
expect(user.account.reload.moved_to_account_id).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'when a recent migration already exists ' do
|
|
let(:acct) { Fabricate(:account, also_known_as: [ActivityPub::TagManager.instance.uri_for(user.account)]) }
|
|
|
|
before do
|
|
moved_to = Fabricate(:account, also_known_as: [ActivityPub::TagManager.instance.uri_for(user.account)])
|
|
user.account.migrations.create!(acct: moved_to.acct)
|
|
end
|
|
|
|
it 'renders show' do
|
|
is_expected.to render_template :show
|
|
end
|
|
|
|
it 'does not update the moved account' do
|
|
expect(user.account.reload.moved_to_account_id).to be_nil
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|