1
0
mirror of https://github.com/funamitech/mastodon synced 2024-11-30 15:58:28 +09:00
YuruToot/app
Nolan Darilek 3b016342c6 Fix accessibility of column headers
As a screen reader user new to Mastodon, I encountered the following issues with the column headers as designed:
 * Jumping between them was difficult. FOr instance, passing my home timeline to reach notification settings was difficult to impossible, especially considering infinite scrolling.
 * There doesn't appear to be any means for triggering the control via the keyboard. the `titleClick` handler only responds to mouse clicks.
 * I didn't even realize there was a Settings toggle until I made this change.

Thanks for using ARIA in your designs. It's a huge help. But adding a `button` role doesn't add keyboard handling and other button behavior. Also, because the role was on the heading container, it obscured the controls within the container itself. This fix resolve that. It also exposes the headings as headings rather than buttons, enabling skipping columns by using screen readers' heading navigation commands.

Since I myself am blind, if this fix requires additional visual styling, I'd like help applying that so it can be merged. I'd consider it an essential accessibility fix for my and other blind users' existence on the platform. Thanks!
2018-01-04 10:25:26 -06:00
..
controllers Make sure private toots remain private and do not end up in HTTP caches (#6175) 2018-01-04 14:39:38 +01:00
helpers Fallback default thumbnail in instance status API (#6177) 2018-01-04 15:36:55 +01:00
javascript Fix accessibility of column headers 2018-01-04 10:25:26 -06:00
lib Don't normalize URLs in toots (#6134) 2018-01-03 20:51:33 +01:00
mailers Add confirmation step for email changes (#6071) 2018-01-02 16:55:00 +01:00
models Allow to dereference Follow object for ActivityPub (#5772) 2018-01-03 18:08:57 +01:00
policies Allow admin to deactivate invite created by users (#5860) 2017-12-01 12:26:19 +01:00
presenters Using double splat operator (#5859) 2017-12-06 11:41:57 +01:00
serializers Fallback default thumbnail in instance status API (#6177) 2018-01-04 15:36:55 +01:00
services Send one Delete of Actor in ActivityPub when account is suspended (#6172) 2018-01-04 14:40:49 +01:00
validators Limit users to 50 lists, remove pagination from lists API (#5933) 2017-12-09 01:32:29 +01:00
views Allow to dereference Follow object for ActivityPub (#5772) 2018-01-03 18:08:57 +01:00
workers Lists redis clean-up (#5886) 2017-12-05 23:20:27 +01:00