mirror of
https://github.com/funamitech/mastodon
synced 2024-11-27 22:38:42 +09:00
Fail ESLint for Warnings in CI (#24836)
This commit is contained in:
parent
27bafabb64
commit
f95125bd04
2
.github/workflows/lint-js.yml
vendored
2
.github/workflows/lint-js.yml
vendored
@ -48,7 +48,7 @@ jobs:
|
|||||||
run: yarn --frozen-lockfile
|
run: yarn --frozen-lockfile
|
||||||
|
|
||||||
- name: ESLint
|
- name: ESLint
|
||||||
run: yarn test:lint:js
|
run: yarn test:lint:js --max-warnings 0
|
||||||
|
|
||||||
- name: Typecheck
|
- name: Typecheck
|
||||||
run: yarn test:typecheck
|
run: yarn test:typecheck
|
||||||
|
@ -21,10 +21,9 @@ export default class ColumnBackButton extends React.PureComponent {
|
|||||||
|
|
||||||
if (onClick) {
|
if (onClick) {
|
||||||
onClick();
|
onClick();
|
||||||
}
|
|
||||||
// Check if there is a previous page in the app to go back to per https://stackoverflow.com/a/70532858/9703201
|
// Check if there is a previous page in the app to go back to per https://stackoverflow.com/a/70532858/9703201
|
||||||
// When upgrading to V6, check `location.key !== 'default'` instead per https://github.com/remix-run/history/blob/main/docs/api-reference.md#location
|
// When upgrading to V6, check `location.key !== 'default'` instead per https://github.com/remix-run/history/blob/main/docs/api-reference.md#location
|
||||||
else if (router.location.key) {
|
} else if (router.location.key) {
|
||||||
router.history.goBack();
|
router.history.goBack();
|
||||||
} else {
|
} else {
|
||||||
router.history.push('/');
|
router.history.push('/');
|
||||||
|
Loading…
Reference in New Issue
Block a user