2017-06-04 21:59:40 +09:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'rails_helper'
|
|
|
|
|
2024-09-04 14:12:25 +09:00
|
|
|
RSpec.describe FetchOEmbedService do
|
2018-05-03 01:58:48 +09:00
|
|
|
subject { described_class.new }
|
|
|
|
|
|
|
|
before do
|
2023-02-19 07:38:14 +09:00
|
|
|
stub_request(:get, 'https://host.test/provider.json').to_return(status: 404)
|
|
|
|
stub_request(:get, 'https://host.test/provider.xml').to_return(status: 404)
|
|
|
|
stub_request(:get, 'https://host.test/empty_provider.json').to_return(status: 200)
|
2018-05-03 01:58:48 +09:00
|
|
|
end
|
|
|
|
|
2017-06-04 21:59:40 +09:00
|
|
|
describe 'discover_provider' do
|
|
|
|
context 'when status code is 200 and MIME type is text/html' do
|
2021-10-22 03:39:35 +09:00
|
|
|
context 'when OEmbed endpoint contains URL as parameter' do
|
|
|
|
before do
|
|
|
|
stub_request(:get, 'https://www.youtube.com/watch?v=IPSbNdBmWKE').to_return(
|
|
|
|
status: 200,
|
|
|
|
headers: { 'Content-Type': 'text/html' },
|
2023-02-18 20:39:58 +09:00
|
|
|
body: request_fixture('oembed_youtube.html')
|
2021-10-22 03:39:35 +09:00
|
|
|
)
|
|
|
|
stub_request(:get, 'https://www.youtube.com/oembed?format=json&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DIPSbNdBmWKE').to_return(
|
|
|
|
status: 200,
|
|
|
|
headers: { 'Content-Type': 'text/html' },
|
|
|
|
body: request_fixture('oembed_json_empty.html')
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns new OEmbed::Provider for JSON provider' do
|
|
|
|
subject.call('https://www.youtube.com/watch?v=IPSbNdBmWKE')
|
|
|
|
expect(subject.endpoint_url).to eq 'https://www.youtube.com/oembed?format=json&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DIPSbNdBmWKE'
|
|
|
|
expect(subject.format).to eq :json
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'stores URL template' do
|
|
|
|
subject.call('https://www.youtube.com/watch?v=IPSbNdBmWKE')
|
|
|
|
expect(Rails.cache.read('oembed_endpoint:www.youtube.com')[:endpoint]).to eq 'https://www.youtube.com/oembed?format=json&url={url}'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-04 12:49:08 +09:00
|
|
|
context 'when both of JSON and XML provider are discoverable' do
|
2017-06-04 21:59:40 +09:00
|
|
|
before do
|
2018-04-25 21:12:28 +09:00
|
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
2017-06-04 21:59:40 +09:00
|
|
|
status: 200,
|
|
|
|
headers: { 'Content-Type': 'text/html' },
|
|
|
|
body: request_fixture('oembed_json_xml.html')
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns new OEmbed::Provider for JSON provider if :format option is set to :json' do
|
2018-05-03 01:58:48 +09:00
|
|
|
subject.call('https://host.test/oembed.html', format: :json)
|
|
|
|
expect(subject.endpoint_url).to eq 'https://host.test/provider.json'
|
|
|
|
expect(subject.format).to eq :json
|
2017-06-04 21:59:40 +09:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns new OEmbed::Provider for XML provider if :format option is set to :xml' do
|
2018-05-03 01:58:48 +09:00
|
|
|
subject.call('https://host.test/oembed.html', format: :xml)
|
|
|
|
expect(subject.endpoint_url).to eq 'https://host.test/provider.xml'
|
|
|
|
expect(subject.format).to eq :xml
|
2017-06-04 21:59:40 +09:00
|
|
|
end
|
2021-10-22 03:39:35 +09:00
|
|
|
|
|
|
|
it 'does not cache OEmbed endpoint' do
|
|
|
|
subject.call('https://host.test/oembed.html', format: :xml)
|
2023-02-20 14:14:50 +09:00
|
|
|
expect(Rails.cache.exist?('oembed_endpoint:host.test')).to be false
|
2021-10-22 03:39:35 +09:00
|
|
|
end
|
2017-06-04 21:59:40 +09:00
|
|
|
end
|
|
|
|
|
2023-05-04 12:49:08 +09:00
|
|
|
context 'when JSON provider is discoverable while XML provider is not' do
|
2017-06-04 21:59:40 +09:00
|
|
|
before do
|
2018-04-25 21:12:28 +09:00
|
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
2017-06-04 21:59:40 +09:00
|
|
|
status: 200,
|
|
|
|
headers: { 'Content-Type': 'text/html' },
|
|
|
|
body: request_fixture('oembed_json.html')
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns new OEmbed::Provider for JSON provider' do
|
2018-05-03 01:58:48 +09:00
|
|
|
subject.call('https://host.test/oembed.html')
|
|
|
|
expect(subject.endpoint_url).to eq 'https://host.test/provider.json'
|
|
|
|
expect(subject.format).to eq :json
|
2017-06-04 21:59:40 +09:00
|
|
|
end
|
2021-10-22 03:39:35 +09:00
|
|
|
|
|
|
|
it 'does not cache OEmbed endpoint' do
|
|
|
|
subject.call('https://host.test/oembed.html')
|
2023-02-20 14:14:50 +09:00
|
|
|
expect(Rails.cache.exist?('oembed_endpoint:host.test')).to be false
|
2021-10-22 03:39:35 +09:00
|
|
|
end
|
2017-06-04 21:59:40 +09:00
|
|
|
end
|
|
|
|
|
2023-05-04 12:49:08 +09:00
|
|
|
context 'when XML provider is discoverable while JSON provider is not' do
|
2017-06-04 21:59:40 +09:00
|
|
|
before do
|
2018-04-25 21:12:28 +09:00
|
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
2017-06-04 21:59:40 +09:00
|
|
|
status: 200,
|
|
|
|
headers: { 'Content-Type': 'text/html' },
|
|
|
|
body: request_fixture('oembed_xml.html')
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns new OEmbed::Provider for XML provider' do
|
2018-05-03 01:58:48 +09:00
|
|
|
subject.call('https://host.test/oembed.html')
|
|
|
|
expect(subject.endpoint_url).to eq 'https://host.test/provider.xml'
|
|
|
|
expect(subject.format).to eq :xml
|
2017-06-04 21:59:40 +09:00
|
|
|
end
|
2021-10-22 03:39:35 +09:00
|
|
|
|
|
|
|
it 'does not cache OEmbed endpoint' do
|
|
|
|
subject.call('https://host.test/oembed.html')
|
2023-02-20 14:14:50 +09:00
|
|
|
expect(Rails.cache.exist?('oembed_endpoint:host.test')).to be false
|
2021-10-22 03:39:35 +09:00
|
|
|
end
|
2017-06-04 21:59:40 +09:00
|
|
|
end
|
|
|
|
|
2023-05-04 12:49:08 +09:00
|
|
|
context 'with Invalid XML provider is discoverable while JSON provider is not' do
|
2017-06-04 21:59:40 +09:00
|
|
|
before do
|
2018-04-25 21:12:28 +09:00
|
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
2017-06-04 21:59:40 +09:00
|
|
|
status: 200,
|
|
|
|
headers: { 'Content-Type': 'text/html' },
|
|
|
|
body: request_fixture('oembed_invalid_xml.html')
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2018-05-03 01:58:48 +09:00
|
|
|
it 'returns nil' do
|
|
|
|
expect(subject.call('https://host.test/oembed.html')).to be_nil
|
2017-06-04 21:59:40 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-04 12:49:08 +09:00
|
|
|
context 'with neither of JSON and XML provider is discoverable' do
|
2017-06-04 21:59:40 +09:00
|
|
|
before do
|
2018-04-25 21:12:28 +09:00
|
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
2017-06-04 21:59:40 +09:00
|
|
|
status: 200,
|
|
|
|
headers: { 'Content-Type': 'text/html' },
|
|
|
|
body: request_fixture('oembed_undiscoverable.html')
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2018-05-03 01:58:48 +09:00
|
|
|
it 'returns nil' do
|
|
|
|
expect(subject.call('https://host.test/oembed.html')).to be_nil
|
2017-06-04 21:59:40 +09:00
|
|
|
end
|
|
|
|
end
|
2019-01-15 01:28:41 +09:00
|
|
|
|
2023-05-04 12:49:08 +09:00
|
|
|
context 'when empty JSON provider is discoverable' do
|
2019-01-15 01:28:41 +09:00
|
|
|
before do
|
|
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
|
|
status: 200,
|
|
|
|
headers: { 'Content-Type': 'text/html' },
|
|
|
|
body: request_fixture('oembed_json_empty.html')
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns new OEmbed::Provider for JSON provider' do
|
|
|
|
subject.call('https://host.test/oembed.html')
|
|
|
|
expect(subject.endpoint_url).to eq 'https://host.test/empty_provider.json'
|
|
|
|
expect(subject.format).to eq :json
|
|
|
|
end
|
|
|
|
end
|
2017-06-04 21:59:40 +09:00
|
|
|
end
|
|
|
|
|
2019-11-18 02:40:33 +09:00
|
|
|
context 'when endpoint is cached' do
|
|
|
|
before do
|
|
|
|
stub_request(:get, 'http://www.youtube.com/oembed?format=json&url=https://www.youtube.com/watch?v=dqwpQarrDwk').to_return(
|
|
|
|
status: 200,
|
|
|
|
headers: { 'Content-Type': 'text/html' },
|
|
|
|
body: request_fixture('oembed_json_empty.html')
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns new provider without fetching original URL first' do
|
|
|
|
subject.call('https://www.youtube.com/watch?v=dqwpQarrDwk', cached_endpoint: { endpoint: 'http://www.youtube.com/oembed?format=json&url={url}', format: :json })
|
|
|
|
expect(a_request(:get, 'https://www.youtube.com/watch?v=dqwpQarrDwk')).to_not have_been_made
|
|
|
|
expect(subject.endpoint_url).to eq 'http://www.youtube.com/oembed?format=json&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DdqwpQarrDwk'
|
|
|
|
expect(subject.format).to eq :json
|
|
|
|
expect(a_request(:get, 'http://www.youtube.com/oembed?format=json&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DdqwpQarrDwk')).to have_been_made
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-06-04 21:59:40 +09:00
|
|
|
context 'when status code is not 200' do
|
|
|
|
before do
|
2018-04-25 21:12:28 +09:00
|
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
2017-06-04 21:59:40 +09:00
|
|
|
status: 400,
|
|
|
|
headers: { 'Content-Type': 'text/html' },
|
|
|
|
body: request_fixture('oembed_xml.html')
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2018-05-03 01:58:48 +09:00
|
|
|
it 'returns nil' do
|
|
|
|
expect(subject.call('https://host.test/oembed.html')).to be_nil
|
2017-06-04 21:59:40 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when MIME type is not text/html' do
|
|
|
|
before do
|
2018-04-25 21:12:28 +09:00
|
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
2017-06-04 21:59:40 +09:00
|
|
|
status: 200,
|
|
|
|
body: request_fixture('oembed_xml.html')
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2018-05-03 01:58:48 +09:00
|
|
|
it 'returns nil' do
|
|
|
|
expect(subject.call('https://host.test/oembed.html')).to be_nil
|
2017-06-04 21:59:40 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|