0
0
Fork 0

Add Api::ErrorHandling concern for api/base controller (#29574)

This commit is contained in:
Matt Jankowski 2024-03-14 05:09:47 -04:00 committed by GitHub
parent 1e1d97a787
commit f9100743ec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 104 additions and 81 deletions

View file

@ -3,10 +3,6 @@
require 'rails_helper'
describe Api::BaseController do
before do
stub_const('FakeService', Class.new)
end
controller do
def success
head 200
@ -72,36 +68,4 @@ describe Api::BaseController do
expect(response).to have_http_status(403)
end
end
describe 'error handling' do
before do
routes.draw { get 'failure' => 'api/base#failure' }
end
{
ActiveRecord::RecordInvalid => 422,
ActiveRecord::RecordNotFound => 404,
ActiveRecord::RecordNotUnique => 422,
Date::Error => 422,
HTTP::Error => 503,
Mastodon::InvalidParameterError => 400,
Mastodon::NotPermittedError => 403,
Mastodon::RaceConditionError => 503,
Mastodon::RateLimitExceededError => 429,
Mastodon::UnexpectedResponseError => 503,
Mastodon::ValidationError => 422,
OpenSSL::SSL::SSLError => 503,
Seahorse::Client::NetworkingError => 503,
Stoplight::Error::RedLight => 503,
}.each do |error, code|
it "Handles error class of #{error}" do
allow(FakeService).to receive(:new).and_raise(error)
get :failure
expect(response).to have_http_status(code)
expect(FakeService).to have_received(:new)
end
end
end
end