Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Expand coverage for admin/metrics/dimension/* classes (#29913)

Browse source
This commit is contained in:
Matt Jankowski 2024-04-12 05:18:35 -04:00 • committed by GitHub
parent 13bbde2246
commit ec5a0e0f5e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 137 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

19
spec/lib/admin/metrics/dimension/sources_dimension_spec.rb
View file

@ -3,7 +3,7 @@
require 'rails_helper'
describe Admin::Metrics::Dimension::SourcesDimension do
subject(:dimension) { described_class.new(start_at, end_at, limit, params) }
subject { described_class.new(start_at, end_at, limit, params) }
let(:start_at) { 2.days.ago }
let(:end_at) { Time.now.utc }
@ -11,8 +11,21 @@ describe Admin::Metrics::Dimension::SourcesDimension do
let(:params) { ActionController::Parameters.new }
describe '#data' do
it 'runs data query without error' do
expect { dimension.data }.to_not raise_error
let(:app) { Fabricate(:application) }
let(:alice) { Fabricate(:user) }
let(:bob) { Fabricate(:user) }
before do
alice.update(created_by_application: app)
end
it 'returns OAuth applications with user counts' do
expect(subject.data.size)
.to eq(1)
expect(subject.data.map(&:symbolize_keys))
.to contain_exactly(
include(key: app.name, value: '1')
)
end
end
end