Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Improve api/v1/markers#create performance against simultaneous requests (#28718)

Browse source
This commit is contained in:
Matt Jankowski 2024-01-15 04:47:25 -05:00 • committed by GitHub
parent cc3ff66246
commit e72676e83a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

58
spec/controllers/api/v1/markers_controller_spec.rb
View file

@ -1,58 +0,0 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe Api::V1::MarkersController do
render_views
let!(:user) { Fabricate(:user) }
let!(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'read:statuses write:statuses') }
before { allow(controller).to receive(:doorkeeper_token) { token } }
describe 'GET #index' do
before do
Fabricate(:marker, timeline: 'home', last_read_id: 123, user: user)
Fabricate(:marker, timeline: 'notifications', last_read_id: 456, user: user)
get :index, params: { timeline: %w(home notifications) }
end
it 'returns markers', :aggregate_failures do
json = body_as_json
expect(response).to have_http_status(200)
expect(json.key?(:home)).to be true
expect(json[:home][:last_read_id]).to eq '123'
expect(json.key?(:notifications)).to be true
expect(json[:notifications][:last_read_id]).to eq '456'
end
end
describe 'POST #create' do
context 'when no marker exists' do
before do
post :create, params: { home: { last_read_id: '69420' } }
end
it 'creates a marker', :aggregate_failures do
expect(response).to have_http_status(200)
expect(user.markers.first.timeline).to eq 'home'
expect(user.markers.first.last_read_id).to eq 69_420
end
end
context 'when a marker exists' do
before do
post :create, params: { home: { last_read_id: '69420' } }
post :create, params: { home: { last_read_id: '70120' } }
end
it 'updates a marker', :aggregate_failures do
expect(response).to have_http_status(200)
expect(user.markers.first.timeline).to eq 'home'
expect(user.markers.first.last_read_id).to eq 70_120
end
end
end
end