Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Replace incorrect use of distinct with group (#14675)

Browse source 
Some uses of ActiveRecord::QueryMethods#distinct pass field names but they
are incorrect for the current version of Rails.

ActiveRecord::QueryMethods#group provides the expected behavior and
benefits performance. See commit 6da24aad4cafdef8d8a2c92bac2002a5fc2fe9c8.
This commit is contained in:
Akihiko Odaki 2020-08-28 19:29:59 +09:00 • committed by GitHub
parent 552e886b64
commit e26e7a1cb5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/controllers/api/v1/timelines/public_controller.rb
View file

@ -30,9 +30,7 @@ class Api::V1::Timelines::PublicController < Api::BaseController
)
if truthy_param?(:only_media)
# `SELECT DISTINCT id, updated_at` is too slow, so pluck ids at first, and then select id, updated_at with ids.
status_ids = statuses.joins(:media_attachments).distinct(:id).pluck(:id)
statuses.where(id: status_ids)
statuses.joins(:media_attachments).group(:id)
else
statuses
end