Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Add list of lists component to web UI (#5811)

Browse source 
* Add list of lists component to web UI

* Add list adding

* Add list removing

* List editor modal

* Add API account search limited by following=true relation

* Rework list editor modal

* Remove mandatory pagination of GET /api/v1/lists/:id/accounts

* Adjust search input placeholder

* Fix rspec (#5890)

* i18n: (zh-CN) Add missing translations for #5811 (#5891)

* i18n: (zh-CN) yarn manage:translations -- zh-CN

* i18n: (zh-CN) Add missing translations for #5811

* Fix some issues

- Display loading/missing state for list timelines
- Order lists alphabetically in overview
- Fix async list editor reset
- Redirect to /lists after deleting unpinned list
- Redirect to / after pinning a list

* Remove dead list columns when a list is deleted or fetch returns 404
This commit is contained in:
Eugen Rochko 2017-12-05 23:02:27 +01:00 • committed by GitHub
parent 12cea76634
commit e20895f251
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
27 changed files with 1073 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

10
spec/services/account_search_service_spec.rb
View file

@ -72,7 +72,7 @@ describe AccountSearchService do
describe 'and there is no account provided' do
it 'uses search_for to find matches' do
allow(Account).to receive(:search_for)
subject.call('two@example.com', 10, false, nil)
subject.call('two@example.com', 10, nil, resolve: false)
expect(Account).to have_received(:search_for).with('two example.com', 10)
end
@ -82,9 +82,9 @@ describe AccountSearchService do
it 'uses advanced_search_for to find matches' do
account = Fabricate(:account)
allow(Account).to receive(:advanced_search_for)
subject.call('two@example.com', 10, false, account)
subject.call('two@example.com', 10, account, resolve: false)
expect(Account).to have_received(:advanced_search_for).with('two example.com', account, 10)
expect(Account).to have_received(:advanced_search_for).with('two example.com', account, 10, nil)
end
end
end
@ -125,7 +125,7 @@ describe AccountSearchService do
service = double(call: nil)
allow(ResolveRemoteAccountService).to receive(:new).and_return(service)
results = subject.call('newuser@remote.com', 10, true)
results = subject.call('newuser@remote.com', 10, nil, resolve: true)
expect(service).to have_received(:call).with('newuser@remote.com')
end
@ -133,7 +133,7 @@ describe AccountSearchService do
service = double(call: nil)
allow(ResolveRemoteAccountService).to receive(:new).and_return(service)
results = subject.call('newuser@remote.com', 10, false)
results = subject.call('newuser@remote.com', 10, nil, resolve: false)
expect(service).not_to have_received(:call)
end
end