From e1f278cdf2bdb8ff843f1e8ce618acafea82c321 Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Mon, 10 Mar 2025 04:17:48 -0400 Subject: [PATCH] Convert `admin/webhooks/secrets` spec controller->system (#34109) --- .../admin/webhooks/secrets_controller_spec.rb | 23 ------------------- spec/system/admin/webhooks_spec.rb | 13 +++++++++++ 2 files changed, 13 insertions(+), 23 deletions(-) delete mode 100644 spec/controllers/admin/webhooks/secrets_controller_spec.rb diff --git a/spec/controllers/admin/webhooks/secrets_controller_spec.rb b/spec/controllers/admin/webhooks/secrets_controller_spec.rb deleted file mode 100644 index da3d4f1438..0000000000 --- a/spec/controllers/admin/webhooks/secrets_controller_spec.rb +++ /dev/null @@ -1,23 +0,0 @@ -# frozen_string_literal: true - -require 'rails_helper' - -RSpec.describe Admin::Webhooks::SecretsController do - render_views - - let(:user) { Fabricate(:admin_user) } - - before do - sign_in user, scope: :user - end - - describe 'POST #rotate' do - let(:webhook) { Fabricate(:webhook) } - - it 'returns http success' do - post :rotate, params: { webhook_id: webhook.id } - - expect(response).to redirect_to(admin_webhook_path(webhook)) - end - end -end diff --git a/spec/system/admin/webhooks_spec.rb b/spec/system/admin/webhooks_spec.rb index 6daa896e1a..709752dc9c 100644 --- a/spec/system/admin/webhooks_spec.rb +++ b/spec/system/admin/webhooks_spec.rb @@ -85,6 +85,19 @@ RSpec.describe 'Admin Webhooks' do end end + describe 'Rotate a webhook secret' do + let!(:webhook) { Fabricate :webhook, events: [Webhook::EVENTS.first] } + + it 'rotates secret and returns to page' do + visit admin_webhook_path(webhook) + + expect { click_on I18n.t('admin.webhooks.rotate_secret') } + .to(change { webhook.reload.secret }) + expect(page) + .to have_title(I18n.t('admin.webhooks.title')) + end + end + describe 'Destroy a webhook' do let!(:webhook) { Fabricate :webhook, events: [Webhook::EVENTS.first] }