Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fix N+1s because of association preloaders not actually getting called (#28339)

Browse source
This commit is contained in:
Claire 2023-12-13 08:47:32 +01:00 • committed by GitHub
parent 3f1ec16377
commit dcc24db793
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/models/notification.rb
View file

@ -111,7 +111,7 @@ class Notification < ApplicationRecord
# Instead of using the usual `includes`, manually preload each type.
# If polymorphic associations are loaded with the usual `includes`, other types of associations will be loaded more.
ActiveRecord::Associations::Preloader.new(records: grouped_notifications, associations: associations)
ActiveRecord::Associations::Preloader.new(records: grouped_notifications, associations: associations).call
end
unique_target_statuses = notifications.filter_map(&:target_status).uniq