Unfloyded/Legamunt
0
0
Fork 0
Code Activity

fix(push_subscription): Guard against malformed favourite notification (#4271)

Browse source
This commit is contained in:
Sorin Davidoi 2017-07-19 22:37:52 +02:00 • committed by Eugen Rochko
parent 4f2513337f
commit dcb9497148
2 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
app/models/web/push_subscription.rb
View file

@ -26,8 +26,6 @@ class Web::PushSubscription < ApplicationRecord
before_create :send_welcome_notification
def push(notification)
return unless pushable? notification
name = display_name notification.from_account
title = title_str(name, notification)
body = body_str notification
@ -69,6 +67,10 @@ class Web::PushSubscription < ApplicationRecord
)
end
def pushable?(notification)
data && data.key?('alerts') && data['alerts'][notification.type.to_s]
end
def as_payload
payload = {
id: id,
@ -148,10 +150,6 @@ class Web::PushSubscription < ApplicationRecord
rtl?(body) ? 'rtl' : 'ltr'
end
def pushable?(notification)
data && data.key?('alerts') && data['alerts'][notification.type.to_s]
end
def send_welcome_notification
Webpush.payload_send(
message: JSON.generate(