Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Improve e-mail MX validator and add tests (#9489)

Browse source
This commit is contained in:
Eugen Rochko 2018-12-10 22:53:25 +01:00 • committed by GitHub
parent 3f12c07ff5
commit dbb1ee269f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 94 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

19
app/validators/email_mx_validator.rb
View file

@ -4,7 +4,6 @@ require 'resolv'
class EmailMxValidator < ActiveModel::Validator
def validate(user)
return if Rails.env.test? || Rails.env.development?
user.errors.add(:email, I18n.t('users.invalid_email')) if invalid_mx?(user.email)
end
@ -15,13 +14,23 @@ class EmailMxValidator < ActiveModel::Validator
return true if domain.nil?
records = Resolv::DNS.new.getresources(domain, Resolv::DNS::Resource::IN::MX).to_a.map { |e| e.exchange.to_s }
records = Resolv::DNS.new.getresources(domain, Resolv::DNS::Resource::IN::A).to_a.map { |e| e.address.to_s } if records.empty?
hostnames = []
ips = []
records.empty? || on_blacklist?(records)
Resolv::DNS.open do |dns|
dns.timeouts = 1
hostnames = dns.getresources(domain, Resolv::DNS::Resource::IN::MX).to_a.map { |e| e.exchange.to_s }
([domain] + hostnames).uniq.each do |hostname|
ips.concat(dns.getresources(hostname, Resolv::DNS::Resource::IN::A).to_a.map { |e| e.address.to_s })
end
end
ips.empty? || on_blacklist?(hostnames + ips)
end
def on_blacklist?(values)
EmailDomainBlock.where(domain: values).any?
EmailDomainBlock.where(domain: values.uniq).any?
end
end