Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Reduce .times usage in AccountSearch spec, use constant for default limit (#27946)

Browse source
This commit is contained in:
Matt Jankowski 2023-11-20 04:08:22 -05:00 • committed by GitHub
parent 00c6ebd86f
commit d2aacea8da
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
spec/models/account_spec.rb
View file

@ -450,10 +450,11 @@ RSpec.describe Account do
expect(results).to eq [match]
end
it 'limits by 10 by default' do
11.times.each { Fabricate(:account, display_name: 'Display Name') }
it 'limits via constant by default' do
stub_const('AccountSearch::DEFAULT_LIMIT', 1)
2.times.each { Fabricate(:account, display_name: 'Display Name') }
results = described_class.search_for('display')
expect(results.size).to eq 10
expect(results.size).to eq 1
end
it 'accepts arbitrary limits' do
@ -594,9 +595,10 @@ RSpec.describe Account do
end
it 'limits by 10 by default' do
11.times { Fabricate(:account, display_name: 'Display Name') }
stub_const('AccountSearch::DEFAULT_LIMIT', 1)
2.times { Fabricate(:account, display_name: 'Display Name') }
results = described_class.advanced_search_for('display', account)
expect(results.size).to eq 10
expect(results.size).to eq 1
end
it 'accepts arbitrary limits' do