Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Reduce .times usage in AccountSearch spec, use constant for default limit (#27946)

Browse source
This commit is contained in:
Matt Jankowski 2023-11-20 04:08:22 -05:00 • committed by GitHub
parent 00c6ebd86f
commit d2aacea8da
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/models/concerns/account_search.rb
View file

@ -106,6 +106,8 @@ module AccountSearch
LIMIT :limit OFFSET :offset
SQL
DEFAULT_LIMIT = 10
def searchable_text
PlainTextFormatter.new(note, local?).to_s if discoverable?
end
@ -118,7 +120,7 @@ module AccountSearch
end
class_methods do
def search_for(terms, limit: 10, offset: 0)
def search_for(terms, limit: DEFAULT_LIMIT, offset: 0)
tsquery = generate_query_for_search(terms)
find_by_sql([BASIC_SEARCH_SQL, { limit: limit, offset: offset, tsquery: tsquery }]).tap do |records|
@ -126,7 +128,7 @@ module AccountSearch
end
end
def advanced_search_for(terms, account, limit: 10, following: false, offset: 0)
def advanced_search_for(terms, account, limit: DEFAULT_LIMIT, following: false, offset: 0)
tsquery = generate_query_for_search(terms)
sql_template = following ? ADVANCED_SEARCH_WITH_FOLLOWING : ADVANCED_SEARCH_WITHOUT_FOLLOWING