Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Remove aria-pressed where it's redundant (#19912)

Browse source 
This commit removes aria-pressed attribute from all elements which
contents or other descriptive attributes change in active state,
effectively replacing the meaning of the button, in which case
aria-pressed, an attribute specified whether the button is currently
pressed, would create a confusion. (Spoiler: it's everywhere).

See https://github.com/mastodon/mastodon/issues/13545#issuecomment-1304886969
This commit is contained in:
Sasha Sorokin 2022-11-08 17:31:32 +01:00 • committed by GitHub
parent d70303bba6
commit d055d75172
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 6 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

3
app/javascript/mastodon/components/icon_button.js
View file

@ -16,7 +16,6 @@ export default class IconButton extends React.PureComponent {
onKeyPress: PropTypes.func,
size: PropTypes.number,
active: PropTypes.bool,
pressed: PropTypes.bool,
expanded: PropTypes.bool,
style: PropTypes.object,
activeStyle: PropTypes.object,
@ -98,7 +97,6 @@ export default class IconButton extends React.PureComponent {
icon,
inverted,
overlay,
pressed,
tabIndex,
title,
counter,
@ -143,7 +141,6 @@ export default class IconButton extends React.PureComponent {
<button
type='button'
aria-label={title}
aria-pressed={pressed}
aria-expanded={expanded}
title={title}
className={classes}