0
0
Fork 0

Fix RSpec/InferredSpecType cop (#24736)

This commit is contained in:
Matt Jankowski 2023-05-03 23:49:53 -04:00 committed by GitHub
parent 710745e16b
commit c97b611b6b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
171 changed files with 170 additions and 345 deletions

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe AboutController, type: :controller do
RSpec.describe AboutController do
render_views
describe 'GET #show' do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe AccountsController, type: :controller do
RSpec.describe AccountsController do
render_views
let(:account) { Fabricate(:account) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe ActivityPub::CollectionsController, type: :controller do
RSpec.describe ActivityPub::CollectionsController do
let!(:account) { Fabricate(:account) }
let!(:private_pinned) { Fabricate(:status, account: account, text: 'secret private stuff', visibility: :private) }
let(:remote_account) { nil }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe ActivityPub::FollowersSynchronizationsController, type: :controller do
RSpec.describe ActivityPub::FollowersSynchronizationsController do
let!(:account) { Fabricate(:account) }
let!(:follower_1) { Fabricate(:account, domain: 'example.com', uri: 'https://example.com/users/a') }
let!(:follower_2) { Fabricate(:account, domain: 'example.com', uri: 'https://example.com/users/b') }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe ActivityPub::InboxesController, type: :controller do
RSpec.describe ActivityPub::InboxesController do
let(:remote_account) { nil }
before do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe ActivityPub::OutboxesController, type: :controller do
RSpec.describe ActivityPub::OutboxesController do
let!(:account) { Fabricate(:account) }
shared_examples 'cacheable response' do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe ActivityPub::RepliesController, type: :controller do
RSpec.describe ActivityPub::RepliesController do
let(:status) { Fabricate(:status, visibility: parent_visibility) }
let(:remote_account) { Fabricate(:account, domain: 'foobar.com') }
let(:remote_reply_id) { 'https://foobar.com/statuses/1234' }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Admin::AccountModerationNotesController, type: :controller do
RSpec.describe Admin::AccountModerationNotesController do
render_views
let(:user) { Fabricate(:user, role: UserRole.find_by(name: 'Admin')) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Admin::AccountsController, type: :controller do
RSpec.describe Admin::AccountsController do
render_views
before { sign_in current_user, scope: :user }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe Admin::ActionLogsController, type: :controller do
describe Admin::ActionLogsController do
render_views
# Action logs typically cause issues when their targets are not in the database

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe Admin::BaseController, type: :controller do
describe Admin::BaseController do
controller do
def success
authorize :dashboard, :index?

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Admin::ChangeEmailsController, type: :controller do
RSpec.describe Admin::ChangeEmailsController do
render_views
let(:admin) { Fabricate(:user, role: UserRole.find_by(name: 'Admin')) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Admin::ConfirmationsController, type: :controller do
RSpec.describe Admin::ConfirmationsController do
render_views
before do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe Admin::DashboardController, type: :controller do
describe Admin::DashboardController do
render_views
describe 'GET #index' do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Admin::Disputes::AppealsController, type: :controller do
RSpec.describe Admin::Disputes::AppealsController do
render_views
before { sign_in current_user, scope: :user }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Admin::DomainAllowsController, type: :controller do
RSpec.describe Admin::DomainAllowsController do
render_views
before do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Admin::DomainBlocksController, type: :controller do
RSpec.describe Admin::DomainBlocksController do
render_views
before do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Admin::EmailDomainBlocksController, type: :controller do
RSpec.describe Admin::EmailDomainBlocksController do
render_views
before do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Admin::ExportDomainAllowsController, type: :controller do
RSpec.describe Admin::ExportDomainAllowsController do
render_views
before do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Admin::ExportDomainBlocksController, type: :controller do
RSpec.describe Admin::ExportDomainBlocksController do
render_views
before do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Admin::InstancesController, type: :controller do
RSpec.describe Admin::InstancesController do
render_views
let(:current_user) { Fabricate(:user, role: UserRole.find_by(name: 'Admin')) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Admin::Settings::BrandingController, type: :controller do
RSpec.describe Admin::Settings::BrandingController do
render_views
describe 'When signed in as an admin' do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Admin::TagsController, type: :controller do
RSpec.describe Admin::TagsController do
render_views
before do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::OEmbedController, type: :controller do
RSpec.describe Api::OEmbedController do
render_views
let(:alice) { Fabricate(:account, username: 'alice') }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Accounts::PinsController, type: :controller do
RSpec.describe Api::V1::Accounts::PinsController do
let(:john) { Fabricate(:user) }
let(:kevin) { Fabricate(:user) }
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: john.id, scopes: 'write:accounts') }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Accounts::SearchController, type: :controller do
RSpec.describe Api::V1::Accounts::SearchController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::AccountsController, type: :controller do
RSpec.describe Api::V1::AccountsController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Admin::AccountActionsController, type: :controller do
RSpec.describe Api::V1::Admin::AccountActionsController do
render_views
let(:role) { UserRole.find_by(name: 'Moderator') }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Admin::AccountsController, type: :controller do
RSpec.describe Api::V1::Admin::AccountsController do
render_views
let(:role) { UserRole.find_by(name: 'Moderator') }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Admin::DomainAllowsController, type: :controller do
RSpec.describe Api::V1::Admin::DomainAllowsController do
render_views
let(:role) { UserRole.find_by(name: 'Admin') }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Admin::DomainBlocksController, type: :controller do
RSpec.describe Api::V1::Admin::DomainBlocksController do
render_views
let(:role) { UserRole.find_by(name: 'Admin') }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Admin::ReportsController, type: :controller do
RSpec.describe Api::V1::Admin::ReportsController do
render_views
let(:role) { UserRole.find_by(name: 'Moderator') }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Announcements::ReactionsController, type: :controller do
RSpec.describe Api::V1::Announcements::ReactionsController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::AnnouncementsController, type: :controller do
RSpec.describe Api::V1::AnnouncementsController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::AppsController, type: :controller do
RSpec.describe Api::V1::AppsController do
render_views
describe 'POST #create' do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::BlocksController, type: :controller do
RSpec.describe Api::V1::BlocksController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::BookmarksController, type: :controller do
RSpec.describe Api::V1::BookmarksController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::ConversationsController, type: :controller do
RSpec.describe Api::V1::ConversationsController do
render_views
let!(:user) { Fabricate(:user, account_attributes: { username: 'alice' }) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::CustomEmojisController, type: :controller do
RSpec.describe Api::V1::CustomEmojisController do
render_views
describe 'GET #index' do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::DomainBlocksController, type: :controller do
RSpec.describe Api::V1::DomainBlocksController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Emails::ConfirmationsController, type: :controller do
RSpec.describe Api::V1::Emails::ConfirmationsController do
let(:confirmed_at) { nil }
let(:user) { Fabricate(:user, confirmed_at: confirmed_at) }
let(:app) { Fabricate(:application) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::EndorsementsController, type: :controller do
RSpec.describe Api::V1::EndorsementsController do
let(:user) { Fabricate(:user) }
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'read:accounts') }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::FavouritesController, type: :controller do
RSpec.describe Api::V1::FavouritesController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::FiltersController, type: :controller do
RSpec.describe Api::V1::FiltersController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::FollowRequestsController, type: :controller do
RSpec.describe Api::V1::FollowRequestsController do
render_views
let(:user) { Fabricate(:user, account_attributes: { locked: true }) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::FollowedTagsController, type: :controller do
RSpec.describe Api::V1::FollowedTagsController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Instances::ActivityController, type: :controller do
RSpec.describe Api::V1::Instances::ActivityController do
describe 'GET #show' do
it 'returns 200' do
get :show

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Instances::PeersController, type: :controller do
RSpec.describe Api::V1::Instances::PeersController do
describe 'GET #index' do
it 'returns 200' do
get :index

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::InstancesController, type: :controller do
RSpec.describe Api::V1::InstancesController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::ListsController, type: :controller do
RSpec.describe Api::V1::ListsController do
render_views
let!(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::MarkersController, type: :controller do
RSpec.describe Api::V1::MarkersController do
render_views
let!(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::MediaController, type: :controller do
RSpec.describe Api::V1::MediaController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::MutesController, type: :controller do
RSpec.describe Api::V1::MutesController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::NotificationsController, type: :controller do
RSpec.describe Api::V1::NotificationsController do
render_views
let(:user) { Fabricate(:user, account_attributes: { username: 'alice' }) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Polls::VotesController, type: :controller do
RSpec.describe Api::V1::Polls::VotesController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::PollsController, type: :controller do
RSpec.describe Api::V1::PollsController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::ReportsController, type: :controller do
RSpec.describe Api::V1::ReportsController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Statuses::FavouritedByAccountsController, type: :controller do
RSpec.describe Api::V1::Statuses::FavouritedByAccountsController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Statuses::RebloggedByAccountsController, type: :controller do
RSpec.describe Api::V1::Statuses::RebloggedByAccountsController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::StatusesController, type: :controller do
RSpec.describe Api::V1::StatusesController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::SuggestionsController, type: :controller do
RSpec.describe Api::V1::SuggestionsController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::TagsController, type: :controller do
RSpec.describe Api::V1::TagsController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V1::Trends::TagsController, type: :controller do
RSpec.describe Api::V1::Trends::TagsController do
render_views
describe 'GET #index' do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V2::Admin::AccountsController, type: :controller do
RSpec.describe Api::V2::Admin::AccountsController do
render_views
let(:role) { UserRole.find_by(name: 'Moderator') }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V2::Filters::KeywordsController, type: :controller do
RSpec.describe Api::V2::Filters::KeywordsController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V2::Filters::StatusesController, type: :controller do
RSpec.describe Api::V2::Filters::StatusesController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V2::FiltersController, type: :controller do
RSpec.describe Api::V2::FiltersController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Api::V2::SearchController, type: :controller do
RSpec.describe Api::V2::SearchController do
render_views
context 'with token' do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe ApplicationController, type: :controller do
describe ApplicationController do
controller do
def success
head 200

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe Auth::ChallengesController, type: :controller do
describe Auth::ChallengesController do
render_views
let(:password) { 'foobar12345' }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe Auth::ConfirmationsController, type: :controller do
describe Auth::ConfirmationsController do
render_views
describe 'GET #new' do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe Auth::PasswordsController, type: :controller do
describe Auth::PasswordsController do
include Devise::Test::ControllerHelpers
describe 'GET #new' do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Auth::RegistrationsController, type: :controller do
RSpec.describe Auth::RegistrationsController do
render_views
shared_examples 'checks for enabled registrations' do |path|

View file

@ -3,7 +3,7 @@
require 'rails_helper'
require 'webauthn/fake_client'
RSpec.describe Auth::SessionsController, type: :controller do
RSpec.describe Auth::SessionsController do
render_views
before do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe ApplicationController, type: :controller do
describe ApplicationController do
controller do
include AccountControllerConcern

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe CacheConcern, type: :controller do
RSpec.describe CacheConcern do
controller(ApplicationController) do
include CacheConcern

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe ChallengableConcern, type: :controller do
RSpec.describe ChallengableConcern do
controller(ApplicationController) do
include ChallengableConcern

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe ApplicationController, type: :controller do
describe ApplicationController do
controller do
include ExportControllerConcern

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe ApplicationController, type: :controller do
describe ApplicationController do
controller do
include Localized

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe ApplicationController, type: :controller do
describe ApplicationController do
let(:wrapped_actor_class) do
Class.new do
attr_reader :wrapped_account

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe ApplicationController, type: :controller do
describe ApplicationController do
controller do
include UserTrackingConcern

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Disputes::AppealsController, type: :controller do
RSpec.describe Disputes::AppealsController do
render_views
before { sign_in current_user, scope: :user }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Disputes::StrikesController, type: :controller do
RSpec.describe Disputes::StrikesController do
render_views
before { sign_in current_user, scope: :user }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe HomeController, type: :controller do
RSpec.describe HomeController do
render_views
describe 'GET #index' do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe InstanceActorsController, type: :controller do
RSpec.describe InstanceActorsController do
describe 'GET #show' do
context 'with JSON' do
let(:format) { 'json' }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe IntentsController, type: :controller do
RSpec.describe IntentsController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Oauth::AuthorizationsController, type: :controller do
RSpec.describe Oauth::AuthorizationsController do
render_views
let(:app) { Doorkeeper::Application.create!(name: 'test', redirect_uri: 'http://localhost/', scopes: 'read') }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Oauth::TokensController, type: :controller do
RSpec.describe Oauth::TokensController do
describe 'POST #revoke' do
let!(:user) { Fabricate(:user) }
let!(:application) { Fabricate(:application, confidential: false) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Settings::ImportsController, type: :controller do
RSpec.describe Settings::ImportsController do
render_views
let(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe Settings::ProfilesController, type: :controller do
RSpec.describe Settings::ProfilesController do
render_views
let!(:user) { Fabricate(:user) }

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe StatusesCleanupController, type: :controller do
RSpec.describe StatusesCleanupController do
render_views
before do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
RSpec.describe TagsController, type: :controller do
RSpec.describe TagsController do
render_views
describe 'GET #show' do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe WellKnown::HostMetaController, type: :controller do
describe WellKnown::HostMetaController do
render_views
describe 'GET #show' do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe WellKnown::NodeInfoController, type: :controller do
describe WellKnown::NodeInfoController do
render_views
describe 'GET #index' do

View file

@ -2,7 +2,7 @@
require 'rails_helper'
describe WellKnown::WebfingerController, type: :controller do
describe WellKnown::WebfingerController do
render_views
describe 'GET #show' do