Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fix FetchLinkCardServices crashing on a tags without a target (#12159)

Browse source 
* Add test for links without targets

* Fix FetchLinkCardServices crashing on a tags without a target
This commit is contained in:
ThibG 2019-11-21 16:04:52 +01:00 • committed by Eugen Rochko
parent e86234b1e9
commit c656cc2191
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/services/fetch_link_card_service.rb
View file

@ -67,7 +67,7 @@ class FetchLinkCardService < BaseService
else
html = Nokogiri::HTML(@status.text)
links = html.css('a')
urls = links.map { |a| Addressable::URI.parse(a['href']).normalize unless skip_link?(a) }.compact
urls = links.map { |a| Addressable::URI.parse(a['href']) unless skip_link?(a) }.compact.map(&:normalize).compact
end
urls.reject { |uri| bad_url?(uri) }.first