Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Handle negative offset param in api/v2/search (#28282)

Browse source
This commit is contained in:
Matt Jankowski 2023-12-19 05:55:39 -05:00 • committed by GitHub
parent 7b1d390734
commit c28976d89e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 30 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

22
spec/requests/api/v2/search_spec.rb
View file

@ -40,7 +40,7 @@ describe 'Search API' do
end
end
context 'with `offset`' do
context 'with valid `offset` value' do
let(:params) { { q: 'test1', offset: 1 } }
it 'returns http unauthorized' do
@ -50,6 +50,26 @@ describe 'Search API' do
end
end
context 'with negative `offset` value' do
let(:params) { { q: 'test1', offset: '-100', type: 'accounts' } }
it 'returns http bad_request' do
get '/api/v2/search', headers: headers, params: params
expect(response).to have_http_status(400)
end
end
context 'with negative `limit` value' do
let(:params) { { q: 'test1', limit: '-100', type: 'accounts' } }
it 'returns http bad_request' do
get '/api/v2/search', headers: headers, params: params
expect(response).to have_http_status(400)
end
end
context 'with following=true' do
let(:params) { { q: 'test', type: 'accounts', following: 'true' } }