Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Handle negative offset param in api/v2/search (#28282)

Browse source
This commit is contained in:
Matt Jankowski 2023-12-19 05:55:39 -05:00 • committed by GitHub
parent 7b1d390734
commit c28976d89e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 30 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/controllers/api/base_controller.rb
View file

@ -108,6 +108,10 @@ class Api::BaseController < ApplicationController
render json: { error: 'Your login is currently disabled' }, status: 403 if current_user&.account&.unavailable?
end
def require_valid_pagination_options!
render json: { error: 'Pagination values for `offset` and `limit` must be positive' }, status: 400 if pagination_options_invalid?
end
def require_user!
if !current_user
render json: { error: 'This method requires an authenticated user' }, status: 422
@ -136,6 +140,10 @@ class Api::BaseController < ApplicationController
private
def pagination_options_invalid?
params.slice(:limit, :offset).values.map(&:to_i).any?(&:negative?)
end
def respond_with_error(code)
render json: { error: Rack::Utils::HTTP_STATUS_CODES[code] }, status: code
end