Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Streaming: Refactor to use metrics.$name instead of destructuring (#31566)

Browse source
This commit is contained in:
Emelia Smith 2024-08-26 10:08:21 +02:00 • committed by GitHub
parent f9f4006a1b
commit c245a2044e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 34 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

17
streaming/metrics.js
View file

@ -4,12 +4,12 @@ import metrics from 'prom-client';
/**
* @typedef StreamingMetrics
* @property {metrics.Registry} register
* @property {metrics.Gauge<"type">} connectedClients
* @property {metrics.Gauge<"type" | "channel">} connectedChannels
* @property {metrics.Gauge} redisSubscriptions
* @property {metrics.Counter} redisMessagesReceived
* @property {metrics.Counter<"type">} messagesSent
* @property {import('express').RequestHandler<{}>} requestHandler
*/
/**
@ -92,8 +92,21 @@ export function setupMetrics(channels, pgPool) {
messagesSent.inc({ type: 'websocket' }, 0);
messagesSent.inc({ type: 'eventsource' }, 0);
/**
* @type {import('express').RequestHandler<{}>}
*/
const requestHandler = (req, res) => {
metrics.register.metrics().then((output) => {
res.set('Content-Type', metrics.register.contentType);
res.end(output);
}).catch((err) => {
req.log.error(err, "Error collecting metrics");
res.status(500).end();
});
};
return {
register: metrics.register,
requestHandler,
connectedClients,
connectedChannels,
redisSubscriptions,