Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fix vacuum scheduler missing lock, locks never expiring (#19458)

Browse source 
Remove vacuuming of orphaned preview cards
This commit is contained in:
Eugen Rochko 2022-10-26 12:10:48 +02:00 • committed by GitHub
parent 1ae508bf2f
commit bf0ab3e0fa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 3 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/lib/vacuum/media_attachments_vacuum.rb
View file

@ -8,8 +8,8 @@ class Vacuum::MediaAttachmentsVacuum
end
def perform
vacuum_cached_files! if retention_period?
vacuum_orphaned_records!
vacuum_cached_files! if retention_period?
end
private

9
app/lib/vacuum/preview_cards_vacuum.rb
View file

@ -9,7 +9,6 @@ class Vacuum::PreviewCardsVacuum
def perform
vacuum_cached_images! if retention_period?
vacuum_orphaned_records!
end
private
@ -21,18 +20,10 @@ class Vacuum::PreviewCardsVacuum
end
end
def vacuum_orphaned_records!
orphaned_preview_cards.in_batches.destroy_all
end
def preview_cards_past_retention_period
PreviewCard.cached.where(PreviewCard.arel_table[:updated_at].lt(@retention_period.ago))
end
def orphaned_preview_cards
PreviewCard.where('NOT EXISTS (SELECT 1 FROM preview_cards_statuses WHERE preview_cards_statuses.preview_card_id = preview_cards.id)').where(PreviewCard.arel_table[:created_at].lt(TTL.ago))
end
def retention_period?
@retention_period.present?
end