Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fix UserTrackingConcern firing on every request, optimize some queries (#5368)

Browse source 
- For some reason, :if option on before_action did not work. It got
  executed every time, returned false, and the action run anyway,
  which led to the current_sign_in_at and sign_in_count being
  updated on every request
- Return "do not filter" early in FeedManager#filter_from_home? if
  the status is authored by receiver. Usually this method is not
  called for own statuses at all, but it is called when Feed#get
  uses the database
- Return early if #reload_stale_associations! has nothing to load
  to save a database query with WHERE 1=0
This commit is contained in:
Eugen Rochko 2017-10-13 16:44:29 +02:00 • committed by GitHub
parent 48f7a58799
commit b8db386e05
4 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
app/lib/feed_manager.rb
View file

@ -115,7 +115,8 @@ class FeedManager
end
def filter_from_home?(status, receiver_id)
return true if status.reply? && (status.in_reply_to_id.nil? || status.in_reply_to_account_id.nil?)
return false if receiver_id == status.account_id
return true if status.reply? && (status.in_reply_to_id.nil? || status.in_reply_to_account_id.nil?)
check_for_mutes = [status.account_id]
check_for_mutes.concat([status.reblog.account_id]) if status.reblog?