Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Improve shouldComponentUpdate for status and status_action_bar (#3323)

Browse source
This commit is contained in:
Nolan Lawson 2017-05-26 05:05:52 -07:00 • committed by Eugen Rochko
parent 7c67cb5997
commit b00cb2aed3
2 changed files with 39 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

11
app/javascript/mastodon/components/status_action_bar.js
View file

@ -4,6 +4,7 @@ import PropTypes from 'prop-types';
import IconButton from './icon_button';
import DropdownMenu from './dropdown_menu';
import { defineMessages, injectIntl } from 'react-intl';
import ImmutablePureComponent from 'react-immutable-pure-component';
const messages = defineMessages({
delete: { id: 'status.delete', defaultMessage: 'Delete' },
@ -21,7 +22,7 @@ const messages = defineMessages({
unmuteConversation: { id: 'status.unmute_conversation', defaultMessage: 'Unmute conversation' },
});
class StatusActionBar extends React.PureComponent {
class StatusActionBar extends ImmutablePureComponent {
static contextTypes = {
router: PropTypes.object,
@ -43,6 +44,14 @@ class StatusActionBar extends React.PureComponent {
intl: PropTypes.object.isRequired,
};
// Avoid checking props that are functions (and whose equality will always
// evaluate to false. See react-immutable-pure-component for usage.
updateOnProps = [
'status',
'me',
'withDismiss',
]
handleReplyClick = () => {
this.props.onReply(this.props.status, this.context.router);
}