Configure brakeman to ignore url safe preview card urls (#25883)
This commit is contained in:
parent
13688539bc
commit
ab0fb81479
5 changed files with 27 additions and 40 deletions
|
@ -0,0 +1,20 @@
|
|||
# frozen_string_literal: true
|
||||
|
||||
require 'rails_helper'
|
||||
|
||||
describe 'admin/trends/links/_preview_card.html.haml' do
|
||||
it 'correctly escapes user supplied url values' do
|
||||
form = instance_double(ActionView::Helpers::FormHelper, check_box: nil)
|
||||
trend = PreviewCardTrend.new(allowed: false)
|
||||
preview_card = Fabricate.build(
|
||||
:preview_card,
|
||||
url: 'https://host.example/path?query=<script>',
|
||||
trend: trend,
|
||||
title: 'Fun'
|
||||
)
|
||||
|
||||
render partial: 'admin/trends/links/preview_card', locals: { preview_card: preview_card, f: form }
|
||||
|
||||
expect(rendered).to include('<a href="https://host.example/path?query=<script>">Fun</a>')
|
||||
end
|
||||
end
|
Loading…
Add table
Add a link
Reference in a new issue