0
0
Fork 0

Change user settings to be stored in a more optimal way (#23630)

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
This commit is contained in:
Eugen Rochko 2023-03-30 14:44:00 +02:00 committed by GitHub
parent e7c3e55874
commit a9b5598c97
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
36 changed files with 817 additions and 525 deletions

View file

@ -0,0 +1,25 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe UserSettings::Namespace do
subject { described_class.new(name) }
let(:name) { :foo }
describe '#setting' do
before do
subject.setting :bar, default: 'baz'
end
it 'adds setting to definitions' do
expect(subject.definitions[:'foo.bar']).to have_attributes(name: :bar, namespace: :foo, default_value: 'baz')
end
end
describe '#definitions' do
it 'returns a hash' do
expect(subject.definitions).to be_a Hash
end
end
end

View file

@ -0,0 +1,74 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe UserSettings::Setting do
subject { described_class.new(name, options) }
let(:name) { :foo }
let(:options) { { default: default, namespace: namespace } }
let(:default) { false }
let(:namespace) { nil }
describe '#default_value' do
context 'when default value is a primitive value' do
it 'returns default value' do
expect(subject.default_value).to eq default
end
end
context 'when default value is a proc' do
let(:default) { -> { 'bar' } }
it 'returns value from proc' do
expect(subject.default_value).to eq 'bar'
end
end
end
describe '#type' do
it 'returns a type' do
expect(subject.type).to be_a ActiveModel::Type::Value
end
end
describe '#type_cast' do
context 'when default value is a boolean' do
let(:default) { false }
it 'returns boolean' do
expect(subject.type_cast('1')).to be true
end
end
context 'when default value is a string' do
let(:default) { '' }
it 'returns string' do
expect(subject.type_cast(1)).to eq '1'
end
end
end
describe '#to_a' do
it 'returns an array' do
expect(subject.to_a).to eq [name, default]
end
end
describe '#key' do
context 'when there is no namespace' do
it 'returnsn a symbol' do
expect(subject.key).to eq :foo
end
end
context 'when there is a namespace' do
let(:namespace) { :bar }
it 'returns a symbol' do
expect(subject.key).to eq :'bar.foo'
end
end
end
end