0
0
Fork 0

Rescue exceptions caused by FetchLinkCardService (#4045)

This commit is contained in:
abcang 2017-07-03 18:03:34 +09:00 committed by Eugen Rochko
parent be94f9e35d
commit a6d02cff36
2 changed files with 8 additions and 2 deletions

View file

@ -10,7 +10,11 @@ module Remotable
method_name = "#{attribute_name}=".to_sym
define_method method_name do |url|
parsed_url = Addressable::URI.parse(url).normalize
begin
parsed_url = Addressable::URI.parse(url).normalize
rescue Addressable::URI::InvalidURIError
return
end
return if !%w(http https).include?(parsed_url.scheme) || parsed_url.host.empty? || self[attribute_name] == url
@ -26,7 +30,7 @@ module Remotable
send("#{attachment_name}_file_name=", filename)
self[attribute_name] = url if has_attribute?(attribute_name)
rescue HTTP::TimeoutError, OpenSSL::SSL::SSLError, Paperclip::Errors::NotIdentifiedByImageMagickError, Addressable::URI::InvalidURIError => e
rescue HTTP::TimeoutError, HTTP::ConnectionError, OpenSSL::SSL::SSLError, Paperclip::Errors::NotIdentifiedByImageMagickError, Addressable::URI::InvalidURIError => e
Rails.logger.debug "Error fetching remote #{attachment_name}: #{e}"
nil
end