Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fixes/do not override timestamps (#7336)

Browse source 
* Revert "Fixes/do not override timestamps (#7331)"

This reverts commit 581a5c9d29.

* Document Snowflake ID corner-case a bit more

Snowflake IDs are used for two purposes: making object identifiers harder to
guess and ensuring they are in chronological order. For this reason, they
are based on the `created_at` attribute of the object.

Unfortunately, inserting items with older snowflakes IDs will break the
assumption of consumers of the paging APIs that new items will always have
a greater identifier than the last seen one.

* Add `override_timestamps` virtual attribute to not correlate snowflake ID with created_at
This commit is contained in:
ThibG 2018-05-03 23:02:46 +02:00 • committed by Eugen Rochko
parent 8c601b54cc
commit a24605961a
8 changed files with 23 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/mastodon/snowflake.rb
View file

@ -7,7 +7,7 @@ module Mastodon::Snowflake
def self.around_create(record)
now = Time.now.utc
if record.created_at.nil? || record.created_at >= now || record.created_at == record.updated_at
if record.created_at.nil? || record.created_at >= now || record.created_at == record.updated_at || record.override_timestamps
yield
else
record.id = Mastodon::Snowflake.id_at(record.created_at)