Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fixes/do not override timestamps (#7336)

Browse source 
* Revert "Fixes/do not override timestamps (#7331)"

This reverts commit 581a5c9d29.

* Document Snowflake ID corner-case a bit more

Snowflake IDs are used for two purposes: making object identifiers harder to
guess and ensuring they are in chronological order. For this reason, they
are based on the `created_at` attribute of the object.

Unfortunately, inserting items with older snowflakes IDs will break the
assumption of consumers of the paging APIs that new items will always have
a greater identifier than the last seen one.

* Add `override_timestamps` virtual attribute to not correlate snowflake ID with created_at
This commit is contained in:
ThibG 2018-05-03 23:02:46 +02:00 • committed by Eugen Rochko
parent 8c601b54cc
commit a24605961a
8 changed files with 23 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/lib/activitypub/activity.rb
View file

@ -78,9 +78,11 @@ class ActivityPub::Activity
notify_about_reblog(status) if reblog_of_local_account?(status)
notify_about_mentions(status)
# Only continue if the status is supposed to have
# arrived in real-time
return unless status.within_realtime_window?
# Only continue if the status is supposed to have arrived in real-time.
# Note that if @options[:override_timestamps] isn't set, the status
# may have a lower snowflake id than other existing statuses, potentially
# "hiding" it from paginated API calls
return unless @options[:override_timestamps] || status.within_realtime_window?
distribute_to_followers(status)
end