0
0
Fork 0

Refactor reply-fetching code and disable it by default (#34147)

This commit is contained in:
Claire 2025-03-12 11:28:06 +01:00 committed by GitHub
parent 46e13dd81c
commit 9db26db495
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 15 additions and 35 deletions

View file

@ -85,7 +85,6 @@ RSpec.describe Status::FetchRepliesConcern do
it 'shows the status as unsubscribed' do
expect(Status.unsubscribed).to eq([status])
expect(status.unsubscribed?).to be(true)
end
end
@ -96,7 +95,6 @@ RSpec.describe Status::FetchRepliesConcern do
it 'shows the status as unsubscribed' do
expect(Status.unsubscribed).to eq([status])
expect(status.unsubscribed?).to be(true)
end
end
@ -107,7 +105,6 @@ RSpec.describe Status::FetchRepliesConcern do
it 'shows the status as unsubscribed' do
expect(Status.unsubscribed).to eq([status])
expect(status.unsubscribed?).to be(true)
end
end
@ -118,14 +115,12 @@ RSpec.describe Status::FetchRepliesConcern do
it 'does not show the status as unsubscribed' do
expect(Status.unsubscribed).to eq([])
expect(status.unsubscribed?).to be(false)
end
end
context 'when the status has no followers' do
it 'shows the status as unsubscribed' do
expect(Status.unsubscribed).to eq([status])
expect(status.unsubscribed?).to be(true)
end
end
end

View file

@ -296,12 +296,6 @@ RSpec.describe ActivityPub::FetchRemoteStatusService do
it_behaves_like 'no delete'
end
end
context 'when the status is from an account with local followers' do
let(:follow) { Fabricate(:follow, account: follower, target_account: sender, created_at: 2.days.ago) }
it_behaves_like 'no delete'
end
end
end

View file

@ -123,6 +123,7 @@ RSpec.describe ActivityPub::FetchAllRepliesWorker do
end
before do
stub_const('Status::FetchRepliesConcern::FETCH_REPLIES_ENABLED', true)
allow(FetchReplyWorker).to receive(:push_bulk)
all_items.each do |item|
next if [top_note_uri, reply_note_uri].include? item