Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Improve email address validation (#14565)

Browse source 
* Increase DNS timeout from 1 second to 5 seconds for MX check

1 seconds is rather short when using a recursive DNS resolver which
hasn't got a cached result already available. Use 5 seconds instead,
which is the timeout value we use for outgoing HTTP queries.

* Add more precise error messages for invalid e-mail addresses
This commit is contained in:
ThibG 2020-08-12 12:40:25 +02:00 • committed by GitHub
parent 7dc4c74265
commit 8d217d7231
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 29 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/admin/email_domain_blocks_controller.rb
View file

@ -27,7 +27,7 @@ module Admin
ips = []
Resolv::DNS.open do |dns|
dns.timeouts = 1
dns.timeouts = 5
hostnames = dns.getresources(@email_domain_block.domain, Resolv::DNS::Resource::IN::MX).to_a.map { |e| e.exchange.to_s }