0
0
Fork 0

Restful refactor of accounts/ routes (#2133)

* Add routing specs for accounts followers and following actions

* Use more restful route naming for public account follow pages

Moves two actions:
- accounts#followers to accounts/follower_accounts#index
- accounts#following to accounts/following_accounts#index

Adds routing spec to ensure prior URLs are preserved.
This commit is contained in:
Matt Jankowski 2017-04-19 07:52:37 -04:00 committed by Eugen
parent c0b30c56db
commit 8bac0350d1
18 changed files with 275 additions and 63 deletions

View file

@ -0,0 +1,24 @@
require 'rails_helper'
describe AccountFollowController do
render_views
let(:user) { Fabricate(:user) }
let(:alice) { Fabricate(:account, username: 'alice') }
describe 'POST #create' do
before do
sign_in(user)
end
it 'redirects to account path' do
service = double
allow(FollowService).to receive(:new).and_return(service)
allow(service).to receive(:call)
post :create, params: { account_username: alice.username }
expect(service).to have_received(:call).with(user.account, 'alice')
expect(response).to redirect_to(account_path(alice))
end
end
end

View file

@ -0,0 +1,24 @@
require 'rails_helper'
describe AccountUnfollowController do
render_views
let(:user) { Fabricate(:user) }
let(:alice) { Fabricate(:account, username: 'alice') }
describe 'POST #create' do
before do
sign_in(user)
end
it 'redirects to account path' do
service = double
allow(UnfollowService).to receive(:new).and_return(service)
allow(service).to receive(:call)
post :create, params: { account_username: alice.username }
expect(service).to have_received(:call).with(user.account, alice)
expect(response).to redirect_to(account_path(alice))
end
end
end

View file

@ -44,18 +44,4 @@ RSpec.describe AccountsController, type: :controller do
end
end
end
describe 'GET #followers' do
it 'returns http success' do
get :followers, params: { username: alice.username }
expect(response).to have_http_status(:success)
end
end
describe 'GET #following' do
it 'returns http success' do
get :following, params: { username: alice.username }
expect(response).to have_http_status(:success)
end
end
end

View file

@ -0,0 +1,14 @@
require 'rails_helper'
describe FollowerAccountsController do
render_views
let(:alice) { Fabricate(:account, username: 'alice') }
describe 'GET #index' do
it 'returns http success' do
get :index, params: { account_username: alice.username }
expect(response).to have_http_status(:success)
end
end
end

View file

@ -0,0 +1,14 @@
require 'rails_helper'
describe FollowingAccountsController do
render_views
let(:alice) { Fabricate(:account, username: 'alice') }
describe 'GET #index' do
it 'returns http success' do
get :index, params: { account_username: alice.username }
expect(response).to have_http_status(:success)
end
end
end