Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Reduce factory creation across controllers/admin specs (#33752)

Browse source
This commit is contained in:
Matt Jankowski 2025-01-28 03:08:16 -05:00 • committed by GitHub
parent 93f3c724ae
commit 8a2d764d34
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 18 additions and 66 deletions
Download patch file Download diff file Expand all files Collapse all files

12
spec/controllers/admin/users/roles_controller_spec.rb
View file

@ -44,11 +44,9 @@ RSpec.describe Admin::Users::RolesController do
let(:permissions) { UserRole::FLAGS[:manage_roles] }
let(:position) { 1 }
it 'updates user role' do
it 'updates user role and redirects' do
expect(user.reload.role_id).to eq selected_role&.id
end
it 'redirects back to account page' do
expect(response).to redirect_to(admin_account_path(user.account_id))
end
end
@ -57,11 +55,9 @@ RSpec.describe Admin::Users::RolesController do
let(:permissions) { UserRole::FLAGS[:administrator] }
let(:position) { 100 }
it 'does not update user role' do
it 'does not update user role and renders edit' do
expect(user.reload.role_id).to eq previous_role&.id
end
it 'renders edit form' do
expect(response).to render_template(:show)
end
end
@ -71,11 +67,9 @@ RSpec.describe Admin::Users::RolesController do
let(:permissions) { UserRole::FLAGS[:manage_roles] }
let(:position) { 1 }
it 'does not update user role' do
it 'does not update user role and returns http forbidden' do
expect(user.reload.role_id).to eq previous_role&.id
end
it 'returns http forbidden' do
expect(response).to have_http_status(403)
end
end