Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Ensure push subscription is immediately removed when application is revoked (#7548)

Browse source 
* Ensure push subscription is immediately removed when application is revoked

* When token is revoked from app, unsubscribe too
This commit is contained in:
Eugen Rochko 2018-05-19 21:05:08 +02:00 • committed by GitHub
parent 5910eb9b61
commit 8378b72eba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 76 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
app/controllers/oauth/authorized_applications_controller.rb
View file

@ -8,6 +8,11 @@ class Oauth::AuthorizedApplicationsController < Doorkeeper::AuthorizedApplicatio
include Localized
def destroy
Web::PushSubscription.unsubscribe_for(params[:id], current_resource_owner)
super
end
private
def store_current_location

14
app/controllers/oauth/tokens_controller.rb Normal file
View file

@ -0,0 +1,14 @@
# frozen_string_literal: true
class Oauth::TokensController < Doorkeeper::TokensController
def revoke
unsubscribe_for_token if authorized? && token.accessible?
super
end
private
def unsubscribe_for_token
Web::PushSubscription.where(access_token_id: token.id).delete_all
end
end