Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fix media attachments without file being uploadable (#12562)

Browse source 
Fix #12554
This commit is contained in:
Eugen Rochko 2020-01-23 21:40:03 +01:00 • committed by GitHub
parent 43daeccccb
commit 81cc86bb1f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 19 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

13
spec/models/media_attachment_spec.rb
View file

@ -31,14 +31,6 @@ RSpec.describe MediaAttachment, type: :model do
context 'file is blank' do
let(:file) { nil }
context 'remote_url is blank' do
let(:remote_url) { '' }
it 'returns false' do
is_expected.to be false
end
end
context 'remote_url is present' do
let(:remote_url) { 'remote_url' }
@ -153,6 +145,11 @@ RSpec.describe MediaAttachment, type: :model do
end
end
it 'is invalid without file' do
media = MediaAttachment.new(account: Fabricate(:account))
expect(media.valid?).to be false
end
describe 'descriptions for remote attachments' do
it 'are cut off at 1500 characters' do
media = Fabricate(:media_attachment, description: 'foo' * 1000, remote_url: 'http://example.com/blah.jpg')