Unify collection caching code
This commit is contained in:
parent
93a90cd9c3
commit
7e90772c92
6 changed files with 30 additions and 87 deletions
|
@ -16,8 +16,8 @@ class Feed
|
|||
RegenerationWorker.perform_async(@account.id, @type)
|
||||
@statuses = Status.send("as_#{@type}_timeline", @account).paginate_by_max_id(limit, nil, nil)
|
||||
else
|
||||
status_map = cache(unhydrated)
|
||||
@statuses = unhydrated.map { |id| status_map[id] }.compact
|
||||
status_map = Status.where(id: unhydrated).map { |s| [s.id, s] }.to_h
|
||||
@statuses = unhydrated.map { |id| status_map[id] }.compact
|
||||
end
|
||||
|
||||
@statuses
|
||||
|
@ -25,29 +25,6 @@ class Feed
|
|||
|
||||
private
|
||||
|
||||
def cache(ids)
|
||||
raw = Status.where(id: ids).to_a
|
||||
uncached_ids = []
|
||||
cached_keys_with_value = Rails.cache.read_multi(*raw.map(&:cache_key))
|
||||
|
||||
raw.each do |status|
|
||||
uncached_ids << status.id unless cached_keys_with_value.key?(status.cache_key)
|
||||
end
|
||||
|
||||
unless uncached_ids.empty?
|
||||
uncached = Status.where(id: uncached_ids).with_includes.map { |s| [s.id, s] }.to_h
|
||||
|
||||
uncached.values.each do |status|
|
||||
Rails.cache.write(status.cache_key, status)
|
||||
end
|
||||
end
|
||||
|
||||
cached = cached_keys_with_value.values.map { |s| [s.id, s] }.to_h
|
||||
cached.merge!(uncached) unless uncached_ids.empty?
|
||||
|
||||
cached
|
||||
end
|
||||
|
||||
def key
|
||||
FeedManager.instance.key(@type, @account.id)
|
||||
end
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue